Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup randomString() #10478

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Cleanup randomString() #10478

merged 1 commit into from
Oct 11, 2019

Conversation

jukie
Copy link
Contributor

@jukie jukie commented Oct 11, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10040

Release note for CHANGELOG:

None - code refactor

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestValidate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestValidate -timeout 120m
=== RUN   TestValidateAppautoscalingPolicyImportInput
--- PASS: TestValidateAppautoscalingPolicyImportInput (0.00s)
=== RUN   TestValidateCloudWatchLogStreamName
--- PASS: TestValidateCloudWatchLogStreamName (0.00s)
=== RUN   TestValidateAwsEcsTaskDefinitionContainerDefinitions
--- PASS: TestValidateAwsEcsTaskDefinitionContainerDefinitions (0.00s)
=== RUN   TestValidateIamGroupName
--- PASS: TestValidateIamGroupName (0.00s)
=== RUN   TestValidateIamUserName
--- PASS: TestValidateIamUserName (0.00s)
=== RUN   TestValidateRedshiftClusterDbName
--- PASS: TestValidateRedshiftClusterDbName (0.00s)
=== RUN   TestValidateTypeStringNullableBoolean
--- PASS: TestValidateTypeStringNullableBoolean (0.00s)
=== RUN   TestValidateTypeStringNullableFloat
--- PASS: TestValidateTypeStringNullableFloat (0.00s)
=== RUN   TestValidateCloudWatchDashboardName
--- PASS: TestValidateCloudWatchDashboardName (0.00s)
=== RUN   TestValidateCloudWatchEventRuleName
--- PASS: TestValidateCloudWatchEventRuleName (0.00s)
=== RUN   TestValidateLambdaFunctionName
--- PASS: TestValidateLambdaFunctionName (0.00s)
=== RUN   TestValidateLambdaQualifier
--- PASS: TestValidateLambdaQualifier (0.00s)
=== RUN   TestValidateLambdaPermissionAction
--- PASS: TestValidateLambdaPermissionAction (0.00s)
=== RUN   TestValidateLambdaPermissionEventSourceToken
--- PASS: TestValidateLambdaPermissionEventSourceToken (0.00s)
=== RUN   TestValidateAwsAccountId
--- PASS: TestValidateAwsAccountId (0.00s)
=== RUN   TestValidateArn
--- PASS: TestValidateArn (0.00s)
=== RUN   TestValidateEC2AutomateARN
--- PASS: TestValidateEC2AutomateARN (0.00s)
=== RUN   TestValidatePolicyStatementId
--- PASS: TestValidatePolicyStatementId (0.00s)
=== RUN   TestValidateCIDRNetworkAddress
--- PASS: TestValidateCIDRNetworkAddress (0.00s)
=== RUN   TestValidateLogMetricFilterName
--- PASS: TestValidateLogMetricFilterName (0.00s)
=== RUN   TestValidateLogMetricTransformationName
--- PASS: TestValidateLogMetricTransformationName (0.00s)
=== RUN   TestValidateLogGroupName
--- PASS: TestValidateLogGroupName (0.00s)
=== RUN   TestValidateLogGroupNamePrefix
--- PASS: TestValidateLogGroupNamePrefix (0.00s)
=== RUN   TestValidateS3BucketLifecycleTimestamp
--- PASS: TestValidateS3BucketLifecycleTimestamp (0.00s)
=== RUN   TestValidateSagemakerName
--- PASS: TestValidateSagemakerName (0.00s)
=== RUN   TestValidateDbEventSubscriptionName
--- PASS: TestValidateDbEventSubscriptionName (0.00s)
=== RUN   TestValidateIAMPolicyJsonString
--- PASS: TestValidateIAMPolicyJsonString (0.00s)
=== RUN   TestValidateCloudFormationTemplate
--- PASS: TestValidateCloudFormationTemplate (0.00s)
=== RUN   TestValidateSQSQueueName
--- PASS: TestValidateSQSQueueName (0.00s)
=== RUN   TestValidateSQSFifoQueueName
--- PASS: TestValidateSQSFifoQueueName (0.00s)
=== RUN   TestValidateOnceAWeekWindowFormat
--- PASS: TestValidateOnceAWeekWindowFormat (0.00s)
=== RUN   TestValidateOnceADayWindowFormat
--- PASS: TestValidateOnceADayWindowFormat (0.00s)
=== RUN   TestValidateEcsPlacementConstraint
--- PASS: TestValidateEcsPlacementConstraint (0.00s)
=== RUN   TestValidateEcsPlacementStrategy
--- PASS: TestValidateEcsPlacementStrategy (0.00s)
=== RUN   TestValidateStepFunctionStateMachineName
--- PASS: TestValidateStepFunctionStateMachineName (0.00s)
=== RUN   TestValidateEmrCustomAmiId
--- PASS: TestValidateEmrCustomAmiId (0.00s)
=== RUN   TestValidateDmsEndpointId
--- PASS: TestValidateDmsEndpointId (0.00s)
=== RUN   TestValidateDmsCertificateId
--- PASS: TestValidateDmsCertificateId (0.00s)
=== RUN   TestValidateDmsReplicationInstanceId
--- PASS: TestValidateDmsReplicationInstanceId (0.00s)
=== RUN   TestValidateDmsReplicationSubnetGroupId
--- PASS: TestValidateDmsReplicationSubnetGroupId (0.00s)
=== RUN   TestValidateDmsReplicationTaskId
--- PASS: TestValidateDmsReplicationTaskId (0.00s)
=== RUN   TestValidateAccountAlias
--- PASS: TestValidateAccountAlias (0.00s)
=== RUN   TestValidateIamRoleProfileName
--- PASS: TestValidateIamRoleProfileName (0.00s)
=== RUN   TestValidateIamRoleProfileNamePrefix
--- PASS: TestValidateIamRoleProfileNamePrefix (0.00s)
=== RUN   TestValidateApiGatewayUsagePlanQuotaSettings
--- PASS: TestValidateApiGatewayUsagePlanQuotaSettings (0.00s)
=== RUN   TestValidateElbName
--- PASS: TestValidateElbName (0.00s)
=== RUN   TestValidateElbNamePrefix
--- PASS: TestValidateElbNamePrefix (0.00s)
=== RUN   TestValidateNeptuneEventSubscriptionName
--- PASS: TestValidateNeptuneEventSubscriptionName (0.00s)
=== RUN   TestValidateNeptuneEventSubscriptionNamePrefix
--- PASS: TestValidateNeptuneEventSubscriptionNamePrefix (0.00s)
=== RUN   TestValidateDbSubnetGroupName
--- PASS: TestValidateDbSubnetGroupName (0.00s)
=== RUN   TestValidateNeptuneSubnetGroupName
--- PASS: TestValidateNeptuneSubnetGroupName (0.00s)
=== RUN   TestValidateDbSubnetGroupNamePrefix
--- PASS: TestValidateDbSubnetGroupNamePrefix (0.00s)
=== RUN   TestValidateNeptuneSubnetGroupNamePrefix
--- PASS: TestValidateNeptuneSubnetGroupNamePrefix (0.00s)
=== RUN   TestValidateDbOptionGroupName
--- PASS: TestValidateDbOptionGroupName (0.00s)
=== RUN   TestValidateDbOptionGroupNamePrefix
--- PASS: TestValidateDbOptionGroupNamePrefix (0.00s)
=== RUN   TestValidateDbParamGroupName
--- PASS: TestValidateDbParamGroupName (0.00s)
=== RUN   TestValidateOpenIdURL
--- PASS: TestValidateOpenIdURL (0.00s)
=== RUN   TestValidateAwsKmsName
--- PASS: TestValidateAwsKmsName (0.00s)
=== RUN   TestValidateAwsKmsGrantName
--- PASS: TestValidateAwsKmsGrantName (0.00s)
=== RUN   TestValidateCognitoIdentityPoolName
--- PASS: TestValidateCognitoIdentityPoolName (0.00s)
=== RUN   TestValidateCognitoProviderDeveloperName
--- PASS: TestValidateCognitoProviderDeveloperName (0.00s)
=== RUN   TestValidateCognitoSupportedLoginProviders
--- PASS: TestValidateCognitoSupportedLoginProviders (0.00s)
=== RUN   TestValidateCognitoIdentityProvidersClientId
--- PASS: TestValidateCognitoIdentityProvidersClientId (0.00s)
=== RUN   TestValidateCognitoIdentityProvidersProviderName
--- PASS: TestValidateCognitoIdentityProvidersProviderName (0.00s)
=== RUN   TestValidateCognitoUserPoolEmailVerificationMessage
--- PASS: TestValidateCognitoUserPoolEmailVerificationMessage (0.01s)
=== RUN   TestValidateCognitoUserPoolEmailVerificationSubject
--- PASS: TestValidateCognitoUserPoolEmailVerificationSubject (0.00s)
=== RUN   TestValidateCognitoUserPoolSmsAuthenticationMessage
--- PASS: TestValidateCognitoUserPoolSmsAuthenticationMessage (0.00s)
=== RUN   TestValidateCognitoUserPoolSmsVerificationMessage
--- PASS: TestValidateCognitoUserPoolSmsVerificationMessage (0.00s)
=== RUN   TestValidateWafMetricName
--- PASS: TestValidateWafMetricName (0.00s)
=== RUN   TestValidateIamRoleDescription
--- PASS: TestValidateIamRoleDescription (0.00s)
=== RUN   TestValidateAwsSSMName
--- PASS: TestValidateAwsSSMName (0.00s)
=== RUN   TestValidateBatchName
--- PASS: TestValidateBatchName (0.00s)
=== RUN   TestValidateCognitoRoleMappingsAmbiguousRoleResolutionAgainstType
--- PASS: TestValidateCognitoRoleMappingsAmbiguousRoleResolutionAgainstType (0.00s)
=== RUN   TestValidateCognitoRoleMappingsRulesConfiguration
--- PASS: TestValidateCognitoRoleMappingsRulesConfiguration (0.00s)
=== RUN   TestValidateSecurityGroupRuleDescription
--- PASS: TestValidateSecurityGroupRuleDescription (0.00s)
=== RUN   TestValidateCognitoRoles
--- PASS: TestValidateCognitoRoles (0.00s)
=== RUN   TestValidateKmsKey
--- PASS: TestValidateKmsKey (0.00s)
=== RUN   TestValidateCognitoUserGroupName
--- PASS: TestValidateCognitoUserGroupName (0.00s)
=== RUN   TestValidateCognitoUserPoolId
--- PASS: TestValidateCognitoUserPoolId (0.00s)
=== RUN   TestValidateAmazonSideAsn
--- PASS: TestValidateAmazonSideAsn (0.00s)
=== RUN   TestValidateLaunchTemplateName
--- PASS: TestValidateLaunchTemplateName (0.00s)
=== RUN   TestValidateLaunchTemplateId
--- PASS: TestValidateLaunchTemplateId (0.00s)
=== RUN   TestValidateNeptuneParamGroupName
--- PASS: TestValidateNeptuneParamGroupName (0.00s)
=== RUN   TestValidateNeptuneParamGroupNamePrefix
--- PASS: TestValidateNeptuneParamGroupNamePrefix (0.00s)
=== RUN   TestValidateCloudFrontPublicKeyName
--- PASS: TestValidateCloudFrontPublicKeyName (0.00s)
=== RUN   TestValidateCloudFrontPublicKeyNamePrefix
--- PASS: TestValidateCloudFrontPublicKeyNamePrefix (0.00s)
=== RUN   TestValidateDxConnectionBandWidth
--- PASS: TestValidateDxConnectionBandWidth (0.00s)
=== RUN   TestValidateLbTargetGroupName
--- PASS: TestValidateLbTargetGroupName (0.00s)
=== RUN   TestValidateLbTargetGroupNamePrefix
--- PASS: TestValidateLbTargetGroupNamePrefix (0.00s)
=== RUN   TestValidateSecretManagerSecretName
--- PASS: TestValidateSecretManagerSecretName (0.00s)
=== RUN   TestValidateSecretManagerSecretNamePrefix
--- PASS: TestValidateSecretManagerSecretNamePrefix (0.00s)
=== RUN   TestValidateRoute53ResolverName
--- PASS: TestValidateRoute53ResolverName (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.306s

...

@jukie jukie requested a review from a team October 11, 2019 21:00
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 11, 2019
@jukie
Copy link
Contributor Author

jukie commented Oct 11, 2019

@bflad whenever you have time.
Would also like to get a review on a few older pr's if possible.
#8288
#8384

bflad
bflad approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one non-blocking nit on imports style, thanks @jukie.

aws/validators_test.go
"regexp"
"strings"
"testing"

"github.com/aws/aws-sdk-go/service/cognitoidentity"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The old style of separating third party libraries is preferred in Go.

@bflad bflad added this to the v2.33.0 milestone Oct 11, 2019
@bflad bflad merged commit abd539e into hashicorp:master Oct 11, 2019
@jukie jukie deleted the remove-randomString branch October 12, 2019 04:58
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
partner Contribution from a partner. service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.33.0
Development

Successfully merging this pull request may close these issues.

Refactor Out randomString()
3 participants
@jukie @bflad @justinretzolk