Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import support for aws_waf_geo_match_set resource #10480

Merged
merged 5 commits into from
Nov 15, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9212

Release note for CHANGELOG:

resource/aws_waf_geo_match_set: Support resource import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafGeoMatchSet_'

=== RUN   TestAccAWSWafGeoMatchSet_basic
=== PAUSE TestAccAWSWafGeoMatchSet_basic
=== CONT  TestAccAWSWafGeoMatchSet_basic
--- PASS: TestAccAWSWafGeoMatchSet_basic (45.56s)
=== RUN   TestAccAWSWafGeoMatchSet_changeNameForceNew
=== PAUSE TestAccAWSWafGeoMatchSet_changeNameForceNew
=== CONT  TestAccAWSWafGeoMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafGeoMatchSet_changeNameForceNew (64.69s)
=== RUN   TestAccAWSWafGeoMatchSet_disappears
=== PAUSE TestAccAWSWafGeoMatchSet_disappears
=== CONT  TestAccAWSWafGeoMatchSet_disappears
--- PASS: TestAccAWSWafGeoMatchSet_disappears (39.10s)
=== RUN   TestAccAWSWafGeoMatchSet_changeConstraints
=== PAUSE TestAccAWSWafGeoMatchSet_changeConstraints
=== CONT  TestAccAWSWafGeoMatchSet_changeConstraints
--- PASS: TestAccAWSWafGeoMatchSet_changeConstraints (60.71s)
=== RUN   TestAccAWSWafGeoMatchSet_noConstraints
=== PAUSE TestAccAWSWafGeoMatchSet_noConstraints
=== CONT  TestAccAWSWafGeoMatchSet_noConstraints
--- PASS: TestAccAWSWafGeoMatchSet_noConstraints (38.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	115.066s

...

@DrFaust92 DrFaust92 requested a review from a team October 12, 2019 09:09
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 12, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 15, 2019
@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSWafGeoMatchSet_disappears (11.70s)
--- PASS: TestAccAWSWafGeoMatchSet_noConstraints (22.92s)
--- PASS: TestAccAWSWafGeoMatchSet_changeNameForceNew (30.62s)
--- PASS: TestAccAWSWafGeoMatchSet_changeConstraints (41.17s)
--- PASS: TestAccAWSWafGeoMatchSet_basic (44.38s)

@bflad bflad merged commit 4bcbb6e into hashicorp:master Nov 15, 2019
bflad added a commit that referenced this pull request Nov 15, 2019
bflad added a commit that referenced this pull request Nov 15, 2019
@DrFaust92 DrFaust92 deleted the import-waf-geo-match branch November 15, 2019 17:03
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants