Allow users to set Elastic Beanstalk tags that include Name

[ctreatma]

Elastic Beanstalk automatically creates the Name tag for an Elastic
Beanstalk environment, and that tag is not editable. However, tags
that include Name in the tag name are supported by Elastic Beanstalk.

The aws_elastic_beanstalk_environment resource incorrectly ignored
any tag that includes Name in the tag name. This updates the regex
used for identifying ignored tags so that only a tag with the exact
name Name will be ignored, so that terraform users are not blocked
from creating valid Elastic Beanstalk environment tags.

https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/using-features.tagging.html

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #3963

Release note for CHANGELOG:

resource/aws_elastic_beanstalk_environment: Add support for tags that contain `Name` in the tag name

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSBeanstalkEnv_tagsWithName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSBeanstalkEnv_tagsWithName -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSBeanstalkEnv_tagsWithName
=== PAUSE TestAccAWSBeanstalkEnv_tagsWithName
=== CONT  TestAccAWSBeanstalkEnv_tagsWithName
--- PASS: TestAccAWSBeanstalkEnv_tagsWithName (561.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	564.573s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.727s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.352s [no tests to run]

[ctreatma]

I've added an acceptance test for this change, but I'm unable to run it because the Elastic Beanstalk test config references a solution stack from 2013 that is not available in my AWS accounts: 64bit Amazon Linux running Python. Updating this to a current solution stack caused an 'invalid load balancer config' error from AWS.

[ctreatma]

I was able to track down an account that still has access to the old Python solution stack and use it to run the acceptance tests. The PR description has been updated with the test output. I'll file an issue to update the tests so that they do not require access to an account that has used that stack within the past 30 days.

[ewbankkit]

@ctreatma This should be fixed now with #11599 as the IgnoreElasticbeanstalk method now looks for the exact tag key Name and does not use a regex.
Once it's merged you could rebase and run your new test case to verify.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!