Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for db resources #10582

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Import test refactor for db resources #10582

merged 1 commit into from
Oct 29, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSDBEventSubscription_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDBEventSubscription_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDBEventSubscription_basicUpdate
=== PAUSE TestAccAWSDBEventSubscription_basicUpdate
=== RUN   TestAccAWSDBEventSubscription_disappears
=== PAUSE TestAccAWSDBEventSubscription_disappears
=== RUN   TestAccAWSDBEventSubscription_withPrefix
=== PAUSE TestAccAWSDBEventSubscription_withPrefix
=== RUN   TestAccAWSDBEventSubscription_withSourceIds
=== PAUSE TestAccAWSDBEventSubscription_withSourceIds
=== RUN   TestAccAWSDBEventSubscription_categoryUpdate
=== PAUSE TestAccAWSDBEventSubscription_categoryUpdate
=== CONT  TestAccAWSDBEventSubscription_basicUpdate
=== CONT  TestAccAWSDBEventSubscription_categoryUpdate
=== CONT  TestAccAWSDBEventSubscription_withSourceIds
=== CONT  TestAccAWSDBEventSubscription_withPrefix
=== CONT  TestAccAWSDBEventSubscription_disappears
--- PASS: TestAccAWSDBEventSubscription_disappears (92.32s)
--- PASS: TestAccAWSDBEventSubscription_withPrefix (96.45s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (129.04s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (152.57s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (154.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       155.480s

make testacc TESTARGS="-run=TestAccAWSDBParameterGroup_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDBParameterGroup_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDBParameterGroup_basic
=== PAUSE TestAccAWSDBParameterGroup_basic
=== RUN   TestAccAWSDBParameterGroup_limit
=== PAUSE TestAccAWSDBParameterGroup_limit
=== RUN   TestAccAWSDBParameterGroup_Disappears
=== PAUSE TestAccAWSDBParameterGroup_Disappears
=== RUN   TestAccAWSDBParameterGroup_namePrefix
=== PAUSE TestAccAWSDBParameterGroup_namePrefix
=== RUN   TestAccAWSDBParameterGroup_generatedName
=== PAUSE TestAccAWSDBParameterGroup_generatedName
=== RUN   TestAccAWSDBParameterGroup_withApplyMethod
=== PAUSE TestAccAWSDBParameterGroup_withApplyMethod
=== RUN   TestAccAWSDBParameterGroup_Only
=== PAUSE TestAccAWSDBParameterGroup_Only
=== RUN   TestAccAWSDBParameterGroup_MatchDefault
=== PAUSE TestAccAWSDBParameterGroup_MatchDefault
=== CONT  TestAccAWSDBParameterGroup_basic
=== CONT  TestAccAWSDBParameterGroup_MatchDefault
=== CONT  TestAccAWSDBParameterGroup_limit
=== CONT  TestAccAWSDBParameterGroup_generatedName
=== CONT  TestAccAWSDBParameterGroup_Only
=== CONT  TestAccAWSDBParameterGroup_withApplyMethod
=== CONT  TestAccAWSDBParameterGroup_Disappears
=== CONT  TestAccAWSDBParameterGroup_namePrefix
--- PASS: TestAccAWSDBParameterGroup_Disappears (26.94s)
--- PASS: TestAccAWSDBParameterGroup_Only (34.32s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (37.78s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (38.53s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (39.84s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (43.67s)
--- PASS: TestAccAWSDBParameterGroup_basic (78.79s)
--- PASS: TestAccAWSDBParameterGroup_limit (79.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       81.369s

make testacc TESTARGS="-run=TestAccAWSDBSecurityGroup_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDBSecurityGroup_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDBSecurityGroup_basic
=== PAUSE TestAccAWSDBSecurityGroup_basic
=== CONT  TestAccAWSDBSecurityGroup_basic
--- PASS: TestAccAWSDBSecurityGroup_basic (31.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       32.653s

make testacc TESTARGS="-run=TestAccAWSDBSubnetGroup_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDBSubnetGroup_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDBSubnetGroup_basic
=== PAUSE TestAccAWSDBSubnetGroup_basic
=== RUN   TestAccAWSDBSubnetGroup_namePrefix
=== PAUSE TestAccAWSDBSubnetGroup_namePrefix
=== RUN   TestAccAWSDBSubnetGroup_generatedName
=== PAUSE TestAccAWSDBSubnetGroup_generatedName
=== RUN   TestAccAWSDBSubnetGroup_withUndocumentedCharacters
=== PAUSE TestAccAWSDBSubnetGroup_withUndocumentedCharacters
=== RUN   TestAccAWSDBSubnetGroup_updateDescription
=== PAUSE TestAccAWSDBSubnetGroup_updateDescription
=== CONT  TestAccAWSDBSubnetGroup_basic
=== CONT  TestAccAWSDBSubnetGroup_withUndocumentedCharacters
=== CONT  TestAccAWSDBSubnetGroup_namePrefix
=== CONT  TestAccAWSDBSubnetGroup_updateDescription
=== CONT  TestAccAWSDBSubnetGroup_generatedName
--- PASS: TestAccAWSDBSubnetGroup_namePrefix (66.16s)
--- PASS: TestAccAWSDBSubnetGroup_basic (66.62s)
--- PASS: TestAccAWSDBSubnetGroup_generatedName (66.80s)
--- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (69.84s)
--- PASS: TestAccAWSDBSubnetGroup_updateDescription (111.89s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       113.329s

@ryndaniels ryndaniels requested review from bflad and a team October 21, 2019 15:56
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 21, 2019
@bflad bflad self-assigned this Oct 25, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSDBParameterGroup_Disappears (12.80s)
--- PASS: TestAccAWSDBSecurityGroup_basic (22.47s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (29.81s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (29.91s)
--- PASS: TestAccAWSDBSubnetGroup_generatedName (31.37s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (31.37s)
--- PASS: TestAccAWSDBSubnetGroup_updateDescription (34.02s)
--- PASS: TestAccAWSDBSubnetGroup_basic (34.91s)
--- PASS: TestAccAWSDBSubnetGroup_namePrefix (47.16s)
--- PASS: TestAccAWSDBParameterGroup_Only (54.53s)
--- PASS: TestAccAWSDBParameterGroup_limit (57.37s)
--- PASS: TestAccAWSDBParameterGroup_basic (61.13s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (61.51s)
--- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (63.88s)
--- PASS: TestAccAWSDBEventSubscription_withPrefix (80.43s)
--- PASS: TestAccAWSDBEventSubscription_disappears (87.02s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (87.52s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (119.22s)
--- PASS: TestAccAWSDBEventSubscription_basicUpdate (128.18s)

@bflad bflad added this to the v2.34.0 milestone Oct 28, 2019
@ryndaniels ryndaniels merged commit 2d59ddd into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-db branch October 29, 2019 09:15
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants