Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for launch resources #10645

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSLaunchTemplate_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSLaunchTemplate_basic
=== PAUSE TestAccAWSLaunchTemplate_basic
=== RUN   TestAccAWSLaunchTemplate_disappears
=== PAUSE TestAccAWSLaunchTemplate_disappears
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_EbsOptimized
=== PAUSE TestAccAWSLaunchTemplate_EbsOptimized
=== RUN   TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== PAUSE TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== RUN   TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== RUN   TestAccAWSLaunchTemplate_description
=== PAUSE TestAccAWSLaunchTemplate_description
=== RUN   TestAccAWSLaunchTemplate_update
=== PAUSE TestAccAWSLaunchTemplate_update
=== RUN   TestAccAWSLaunchTemplate_tags
=== PAUSE TestAccAWSLaunchTemplate_tags
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_preference
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_preference
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_target
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_target
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t2
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t2
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t3
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t3
=== RUN   TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== PAUSE TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== RUN   TestAccAWSLaunchTemplate_networkInterface
=== PAUSE TestAccAWSLaunchTemplate_networkInterface
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== RUN   TestAccAWSLaunchTemplate_instanceMarketOptions
=== PAUSE TestAccAWSLaunchTemplate_instanceMarketOptions
=== RUN   TestAccAWSLaunchTemplate_licenseSpecification
=== PAUSE TestAccAWSLaunchTemplate_licenseSpecification
=== CONT  TestAccAWSLaunchTemplate_basic
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_target
=== CONT  TestAccAWSLaunchTemplate_disappears
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== CONT  TestAccAWSLaunchTemplate_instanceMarketOptions
=== CONT  TestAccAWSLaunchTemplate_networkInterface
=== CONT  TestAccAWSLaunchTemplate_tags
=== CONT  TestAccAWSLaunchTemplate_update
=== CONT  TestAccAWSLaunchTemplate_description
=== CONT  TestAccAWSLaunchTemplate_data
=== CONT  TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== CONT  TestAccAWSLaunchTemplate_EbsOptimized
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== CONT  TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t3
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t2
=== CONT  TestAccAWSLaunchTemplate_licenseSpecification
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_preference
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (36.10s)
--- PASS: TestAccAWSLaunchTemplate_disappears (22.63s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (27.53s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (31.60s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (31.64s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (31.72s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (31.77s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (31.79s)
--- PASS: TestAccAWSLaunchTemplate_data (31.83s)
--- PASS: TestAccAWSLaunchTemplate_basic (32.97s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (29.77s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (39.88s)
--- PASS: TestAccAWSLaunchTemplate_description (51.32s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (51.42s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (54.30s)
--- PASS: TestAccAWSLaunchTemplate_tags (54.79s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (68.30s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (84.50s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (86.04s)
--- PASS: TestAccAWSLaunchTemplate_update (86.55s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (111.24s)

make testacc TESTARGS="-run=TestAccAWSLaunchConfiguration_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfiguration_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSLaunchConfiguration_basic
=== PAUSE TestAccAWSLaunchConfiguration_basic
=== RUN   TestAccAWSLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_withBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAWSLaunchConfiguration_withSpotPrice
=== RUN   TestAccAWSLaunchConfiguration_withVpcClassicLink
=== PAUSE TestAccAWSLaunchConfiguration_withVpcClassicLink
=== RUN   TestAccAWSLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAWSLaunchConfiguration_withIAMProfile
=== RUN   TestAccAWSLaunchConfiguration_withEncryption
=== PAUSE TestAccAWSLaunchConfiguration_withEncryption
=== RUN   TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_ebs_noDevice
=== PAUSE TestAccAWSLaunchConfiguration_ebs_noDevice
=== RUN   TestAccAWSLaunchConfiguration_userData
=== PAUSE TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfiguration_basic
=== CONT  TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfiguration_withVpcClassicLink
=== CONT  TestAccAWSLaunchConfiguration_withIAMProfile
=== CONT  TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== CONT  TestAccAWSLaunchConfiguration_withSpotPrice
=== CONT  TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_ebs_noDevice
=== CONT  TestAccAWSLaunchConfiguration_withBlockDevices
=== CONT  TestAccAWSLaunchConfiguration_withEncryption
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (33.05s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (35.92s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (36.65s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (37.26s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (45.42s)
--- PASS: TestAccAWSLaunchConfiguration_basic (57.93s)
--- PASS: TestAccAWSLaunchConfiguration_userData (58.84s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (61.40s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (64.57s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (65.97s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (68.52s)

@ryndaniels ryndaniels requested review from bflad and a team October 28, 2019 10:20
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 28, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (test failure unrelated)

--- PASS: TestAccAWSLaunchTemplate_disappears (13.73s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (17.94s)
--- PASS: TestAccAWSLaunchTemplate_basic (18.04s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (21.44s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (21.36s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (22.70s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (23.04s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (25.40s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (28.07s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (29.02s)
--- PASS: TestAccAWSLaunchTemplate_data (17.60s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (31.96s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (32.49s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (40.19s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (41.45s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (41.79s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (20.23s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (20.59s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (22.63s)
--- PASS: TestAccAWSLaunchConfiguration_basic (45.87s)
--- PASS: TestAccAWSLaunchTemplate_description (28.39s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (21.10s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (18.85s)
--- PASS: TestAccAWSLaunchConfiguration_userData (46.89s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (18.48s)
--- FAIL: TestAccAWSLaunchTemplate_licenseSpecification (6.23s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (16.96s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (16.69s)
--- PASS: TestAccAWSLaunchTemplate_tags (28.65s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (19.02s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (50.96s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (55.20s)
--- PASS: TestAccAWSLaunchTemplate_update (53.68s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (80.87s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (51.45s)

@bflad bflad added this to the v2.34.0 milestone Oct 28, 2019
@ryndaniels ryndaniels merged commit 7e563ed into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-launch branch October 29, 2019 09:22
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants