Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/secretsmanager: Refactor tagging logic to keyvaluetags package #10745

Merged
merged 1 commit into from
Nov 15, 2019

Commits on Nov 4, 2019

  1. service/secretsmanager: Refactor tagging logic to keyvaluetags package

    Reference: #10688
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccDataSourceAwsSecretsManagerSecret_Basic (5.99s)
    --- PASS: TestAccAwsSecretsManagerSecret_Basic (13.99s)
    --- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (14.02s)
    --- PASS: TestAccDataSourceAwsSecretsManagerSecret_ARN (15.28s)
    --- PASS: TestAccDataSourceAwsSecretsManagerSecret_Policy (16.05s)
    --- PASS: TestAccDataSourceAwsSecretsManagerSecret_Name (16.35s)
    --- PASS: TestAccAwsSecretsManagerSecret_policy (17.75s)
    --- PASS: TestAccAwsSecretsManagerSecret_Description (21.89s)
    --- PASS: TestAccAwsSecretsManagerSecret_Tags (38.69s)
    --- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (39.41s)
    --- PASS: TestAccAwsSecretsManagerSecret_RotationRules (50.42s)
    --- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (50.55s)
    --- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (53.23s)
    ```
    bflad committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    f42bdee View commit details
    Browse the repository at this point in the history