r/aws_ami: Refactor tagging logic to keyvaluetags package

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAMI_'
=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== CONT  TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_basic (74.79s)
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_tags
--- PASS: TestAccAWSAMI_tags (139.63s)
=== RUN   TestAccAWSAMI_snapshotSize
=== PAUSE TestAccAWSAMI_snapshotSize
=== CONT  TestAccAWSAMI_snapshotSize
--- PASS: TestAccAWSAMI_snapshotSize (73.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	296.478s

...

[bflad]

Hey @DrFaust92 👋 Thanks for submitting this. Overall this looks good, just left one item that maybe hasn't been mentioned before about using the indexed format verbs and a very minor nit. Please reach out with any questions, thanks again.

[DrFaust92]

@bflad, Thanks for the comments, Updated accordingly.

test results after change:

=== RUN   TestAccAWSAMI_basic
=== PAUSE TestAccAWSAMI_basic
=== CONT  TestAccAWSAMI_basic
--- PASS: TestAccAWSAMI_basic (93.25s)
=== RUN   TestAccAWSAMI_tags
=== PAUSE TestAccAWSAMI_tags
=== CONT  TestAccAWSAMI_tags
=== RUN   TestAccAWSAMI_snapshotSize
=== PAUSE TestAccAWSAMI_snapshotSize
=== CONT  TestAccAWSAMI_snapshotSize
--- PASS: TestAccAWSAMI_snapshotSize (90.15s)
--- PASS: TestAccAWSAMI_tags (152.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	346.919s

[bflad]

LGTM, thanks for those updates, @DrFaust92 🚀

--- PASS: TestAccAWSAMI_snapshotSize (47.60s)
--- PASS: TestAccAWSAMI_basic (48.16s)
--- PASS: TestAccAWSAMI_tags (59.53s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!