r/aws_ec2_fleet: Refactor tagging logic to keyvaluetags package #10761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/S
Closed
7 tasks
ewbankkit
commented
Nov 5, 2019
| @@ -192,12 +193,7 @@ func resourceAwsEc2Fleet() *schema.Resource { | |||
| }, | |||
| }, | |||
| }, | |||
| "tags": { | |||
There was a problem hiding this comment.
There was no reason that updating tags needs to ForceNew.
ewbankkit
commented
Nov 5, 2019
| @@ -475,6 +471,14 @@ func resourceAwsEc2FleetUpdate(d *schema.ResourceData, meta interface{}) error { | |||
| return fmt.Errorf("error waiting for EC2 Fleet (%s) modification: %s", d.Id(), err) | |||
| } | |||
|
|
|||
| if d.HasChange("tags") { | |||
There was a problem hiding this comment.
tags can be updated without forcing new resource.
bflad
added
the
enhancement
bflad
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
LGTM, thanks @ewbankkit 🚀
Output from acceptance testing:
--- SKIP: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_MaxPrice (0.00s)
--- PASS: TestAccAWSEc2Fleet_disappears (42.43s)
--- PASS: TestAccAWSEc2Fleet_basic (42.61s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType (65.16s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority (68.59s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_Version (68.95s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstanceInterruptionBehavior (69.67s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity (69.58s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_InstancePoolsToUseCount (69.90s)
--- PASS: TestAccAWSEc2Fleet_SpotOptions_AllocationStrategy (71.31s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_AvailabilityZone (71.36s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority_Multiple (71.31s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_InstanceType (71.44s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity_Multiple (71.70s)
--- PASS: TestAccAWSEc2Fleet_ReplaceUnhealthyInstances (71.92s)
--- PASS: TestAccAWSEc2Fleet_OnDemandOptions_AllocationStrategy (72.08s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateId (72.12s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_OnDemand (30.06s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_Spot (30.11s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_SubnetId (72.82s)
--- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateName (73.05s)
--- PASS: TestAccAWSEc2Fleet_ExcessCapacityTerminationPolicy (95.00s)
--- PASS: TestAccAWSEc2Fleet_Type (26.85s)
--- PASS: TestAccAWSEc2Fleet_Tags (97.60s)
--- PASS: TestAccAWSEc2Fleet_TerminateInstancesWithExpiration (48.92s)
--- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_TotalTargetCapacity (457.29s)
|
This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #10688.
Release note for CHANGELOG:
Output from acceptance testing: