Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/cloudformation_stack - refactor to use keyvaluetags + enums #10765

Merged
merged 6 commits into from
Nov 6, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudFormationStack_'
=== RUN   TestAccAWSCloudFormationStack_dataSource_basic
=== PAUSE TestAccAWSCloudFormationStack_dataSource_basic
=== CONT  TestAccAWSCloudFormationStack_dataSource_basic
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (101.59s)
=== RUN   TestAccAWSCloudFormationStack_dataSource_yaml
=== PAUSE TestAccAWSCloudFormationStack_dataSource_yaml
=== CONT  TestAccAWSCloudFormationStack_dataSource_yaml
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (98.11s)
=== RUN   TestAccAWSCloudFormationStack_basic
=== PAUSE TestAccAWSCloudFormationStack_basic
=== CONT  TestAccAWSCloudFormationStack_basic
--- PASS: TestAccAWSCloudFormationStack_basic (88.38s)
=== RUN   TestAccAWSCloudFormationStack_disappears
=== PAUSE TestAccAWSCloudFormationStack_disappears
=== CONT  TestAccAWSCloudFormationStack_disappears
--- PASS: TestAccAWSCloudFormationStack_disappears (91.03s)
=== RUN   TestAccAWSCloudFormationStack_yaml
=== PAUSE TestAccAWSCloudFormationStack_yaml
=== CONT  TestAccAWSCloudFormationStack_yaml
--- PASS: TestAccAWSCloudFormationStack_yaml (91.84s)
=== RUN   TestAccAWSCloudFormationStack_defaultParams
=== PAUSE TestAccAWSCloudFormationStack_defaultParams
=== CONT  TestAccAWSCloudFormationStack_defaultParams
--- PASS: TestAccAWSCloudFormationStack_defaultParams (100.43s)
=== RUN   TestAccAWSCloudFormationStack_allAttributes
=== PAUSE TestAccAWSCloudFormationStack_allAttributes
=== CONT  TestAccAWSCloudFormationStack_allAttributes
--- PASS: TestAccAWSCloudFormationStack_allAttributes (136.04s)
=== RUN   TestAccAWSCloudFormationStack_withParams
=== PAUSE TestAccAWSCloudFormationStack_withParams
=== CONT  TestAccAWSCloudFormationStack_withParams
--- PASS: TestAccAWSCloudFormationStack_withParams (167.56s)
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (258.50s)
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (172.91s)
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (231.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1545.851s

...

@DrFaust92 DrFaust92 requested a review from a team November 6, 2019 13:19
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Nov 6, 2019
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 6, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 6, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCloudFormationStack_yaml (63.93s)
--- PASS: TestAccAWSCloudFormationStack_disappears (66.27s)
--- PASS: TestAccAWSCloudFormationStack_basic (66.37s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (59.60s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (74.47s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (64.79s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (75.45s)
--- PASS: TestAccAWSCloudFormationStack_withParams (109.61s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (117.44s)

@bflad bflad merged commit acc7424 into hashicorp:master Nov 6, 2019
@DrFaust92 DrFaust92 deleted the cloudformation-keyvaluetags branch November 7, 2019 11:29
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudformation Issues and PRs that pertain to the cloudformation service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants