aws_ebs_volume: Refactor tagging logic to keyvaluetags package

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEbsVolumeDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEbsVolumeDataSource_ -timeout 120m
=== RUN   TestAccAWSEbsVolumeDataSource_basic
=== PAUSE TestAccAWSEbsVolumeDataSource_basic
=== RUN   TestAccAWSEbsVolumeDataSource_multipleFilters
=== PAUSE TestAccAWSEbsVolumeDataSource_multipleFilters
=== CONT  TestAccAWSEbsVolumeDataSource_multipleFilters
=== CONT  TestAccAWSEbsVolumeDataSource_basic
--- PASS: TestAccAWSEbsVolumeDataSource_basic (30.45s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (30.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.931s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_ -timeout 120m
=== RUN   TestAccAWSEBSVolume_basic
=== PAUSE TestAccAWSEBSVolume_basic
=== RUN   TestAccAWSEBSVolume_updateAttachedEbsVolume
=== PAUSE TestAccAWSEBSVolume_updateAttachedEbsVolume
=== RUN   TestAccAWSEBSVolume_updateSize
=== PAUSE TestAccAWSEBSVolume_updateSize
=== RUN   TestAccAWSEBSVolume_updateType
=== PAUSE TestAccAWSEBSVolume_updateType
=== RUN   TestAccAWSEBSVolume_updateIops
=== PAUSE TestAccAWSEBSVolume_updateIops
=== RUN   TestAccAWSEBSVolume_kmsKey
=== PAUSE TestAccAWSEBSVolume_kmsKey
=== RUN   TestAccAWSEBSVolume_NoIops
=== PAUSE TestAccAWSEBSVolume_NoIops
=== RUN   TestAccAWSEBSVolume_withTags
=== PAUSE TestAccAWSEBSVolume_withTags
=== CONT  TestAccAWSEBSVolume_basic
=== CONT  TestAccAWSEBSVolume_kmsKey
=== CONT  TestAccAWSEBSVolume_updateIops
=== CONT  TestAccAWSEBSVolume_withTags
=== CONT  TestAccAWSEBSVolume_updateType
=== CONT  TestAccAWSEBSVolume_NoIops
=== CONT  TestAccAWSEBSVolume_updateSize
=== CONT  TestAccAWSEBSVolume_updateAttachedEbsVolume
--- PASS: TestAccAWSEBSVolume_withTags (31.58s)
--- PASS: TestAccAWSEBSVolume_NoIops (32.07s)
--- PASS: TestAccAWSEBSVolume_basic (32.43s)
--- PASS: TestAccAWSEBSVolume_updateIops (56.35s)
--- PASS: TestAccAWSEBSVolume_updateType (56.58s)
--- PASS: TestAccAWSEBSVolume_updateSize (56.62s)
--- PASS: TestAccAWSEBSVolume_kmsKey (59.69s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (179.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	179.550s

[bflad]

LGTM, thanks @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEBSVolume_withTags (22.85s)
--- PASS: TestAccAWSEbsVolumeDataSource_basic (23.47s)
--- PASS: TestAccAWSEBSVolume_NoIops (24.20s)
--- PASS: TestAccAWSEBSVolume_basic (24.24s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (24.38s)
--- PASS: TestAccAWSEBSVolume_updateType (39.55s)
--- PASS: TestAccAWSEBSVolume_updateSize (40.22s)
--- PASS: TestAccAWSEBSVolume_updateIops (41.02s)
--- PASS: TestAccAWSEBSVolume_kmsKey (43.46s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (149.67s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!