Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/data_source_aws_iam_group: Retrieve users that are associated to the group #10782

Closed
wants to merge 3 commits into from
Closed

data-source/data_source_aws_iam_group: Retrieve users that are associated to the group #10782

wants to merge 3 commits into from

Conversation

Vince-Chenal
Copy link
Contributor

@Vince-Chenal Vince-Chenal commented Nov 7, 2019

Motivation

It is often handy to have access to the mapping between IAM Groups and IAM Users, especially when you can't directly use the group.

For example, you can't give permissions to a group in a S3 Bucket Policy. You need to explicitly give all the ARNs or UserIDs of the users.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10652

Release note for CHANGELOG:

* data-source/data_source_aws_iam_group: Retrieve users that are associated to the group

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSourceIAMGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMGroup_basic -timeout 120m
=== RUN   TestAccAWSDataSourceIAMGroup_basic
=== PAUSE TestAccAWSDataSourceIAMGroup_basic
=== CONT  TestAccAWSDataSourceIAMGroup_basic
--- PASS: TestAccAWSDataSourceIAMGroup_basic (22.98s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       23.004s
...

@Vince-Chenal Vince-Chenal requested a review from a team November 7, 2019 10:25
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Nov 7, 2019
@bflad
Copy link
Contributor

bflad commented Nov 7, 2019

Hi @Vince-Chenal 👋 Thank you for submitting this.

It appears there might have been some disconnect between the newer feature request #10652 and a previously existing one #7076, where the earlier one had a previously opened pull request #7132. In these situations the maintainers prefer to work through pull requests in their submitted order to be fair to the original contributor and since the original pull request is mostly ready to go except for a few minor feedback items, we are going to opt to close this one to prevent further confusion.

Apologies for any confusion and thank you again for your contribution.

@bflad bflad closed this Nov 7, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAM Group Data Source does not return iam members in group
2 participants