r/cloudformation_stack_set - refactor to use keyvaluetags

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSet_'
=== RUN   TestAccAWSCloudFormationStackSet_basic
=== PAUSE TestAccAWSCloudFormationStackSet_basic
=== CONT  TestAccAWSCloudFormationStackSet_basic
--- PASS: TestAccAWSCloudFormationStackSet_basic (48.62s)
=== RUN   TestAccAWSCloudFormationStackSet_disappears
=== PAUSE TestAccAWSCloudFormationStackSet_disappears
=== CONT  TestAccAWSCloudFormationStackSet_disappears
=== RUN   TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== PAUSE TestAccAWSCloudFormationStackSet_AdministrationRoleArn
=== CONT  TestAccAWSCloudFormationStackSet_AdministrationRoleArn
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (77.75s)
=== RUN   TestAccAWSCloudFormationStackSet_Description
=== PAUSE TestAccAWSCloudFormationStackSet_Description
=== CONT  TestAccAWSCloudFormationStackSet_Description
--- PASS: TestAccAWSCloudFormationStackSet_Description (80.95s)
=== RUN   TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== PAUSE TestAccAWSCloudFormationStackSet_ExecutionRoleName
=== CONT  TestAccAWSCloudFormationStackSet_ExecutionRoleName
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (78.28s)
=== RUN   TestAccAWSCloudFormationStackSet_Name
=== PAUSE TestAccAWSCloudFormationStackSet_Name
=== CONT  TestAccAWSCloudFormationStackSet_Name
--- FAIL: TestAccAWSCloudFormationStackSet_Name (62.11s)
    testing.go:615: Step 6 error: Check failed: Check 2/3 error: CloudFormation Stack Set (tf-acc-test-789837122060625453) not recreated
=== RUN   TestAccAWSCloudFormationStackSet_Parameters
=== PAUSE TestAccAWSCloudFormationStackSet_Parameters
=== CONT  TestAccAWSCloudFormationStackSet_Parameters
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (138.98s)
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_Default
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s)
    resource_aws_cloudformation_stack_set_test.go:300: this resource does not currently ignore unconfigured CloudFormation template parameters with the Default property

Test ignored.
=== RUN   TestAccAWSCloudFormationStackSet_Parameters_NoEcho
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s)
    resource_aws_cloudformation_stack_set_test.go:351: this resource does not currently ignore CloudFormation template parameters with the NoEcho property

Test ignored.
=== RUN   TestAccAWSCloudFormationStackSet_Tags
=== PAUSE TestAccAWSCloudFormationStackSet_Tags
=== CONT  TestAccAWSCloudFormationStackSet_Tags
--- PASS: TestAccAWSCloudFormationStackSet_Tags (143.83s)
=== RUN   TestAccAWSCloudFormationStackSet_TemplateBody
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateBody
=== CONT  TestAccAWSCloudFormationStackSet_TemplateBody
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (77.13s)
=== RUN   TestAccAWSCloudFormationStackSet_TemplateUrl
=== PAUSE TestAccAWSCloudFormationStackSet_TemplateUrl
=== CONT  TestAccAWSCloudFormationStackSet_TemplateUrl
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (173.44s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (42.14s)

...

A single test has failed but i think it's unrelated to the change.

[bflad]

🎉 Should be good to go after this is fixed up.

aws/structure.go:1625:6: `expandCloudFormationTags` is unused (deadcode)
func expandCloudFormationTags(tags map[string]interface{}) []*cloudformation.Tag {
     ^
aws/structure.go:1636:6: `flattenCloudFormationTags` is unused (deadcode)
func flattenCloudFormationTags(cfTags []*cloudformation.Tag) map[string]string {
     ^
GNUmakefile:41: recipe for target 'lint' failed
make: *** [lint] Error 1
The command "make lint" exited with 2.

[bflad]

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s)
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (23.40s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (27.19s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (39.54s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (41.55s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (41.82s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (50.20s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (53.26s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (79.36s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (79.94s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (96.49s)

[ghost]

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!