r/waf_rule- refactor to use keyvaluetags

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

- resource/resource_aws_waf_rule: Add `arn` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafRule_'
=== RUN   TestAccAWSWafRule_basic
=== PAUSE TestAccAWSWafRule_basic
=== CONT  TestAccAWSWafRule_basic
--- PASS: TestAccAWSWafRule_basic (64.90s)
=== RUN   TestAccAWSWafRule_changeNameForceNew
=== PAUSE TestAccAWSWafRule_changeNameForceNew
=== CONT  TestAccAWSWafRule_changeNameForceNew
--- PASS: TestAccAWSWafRule_changeNameForceNew (95.66s)
=== RUN   TestAccAWSWafRule_disappears
=== PAUSE TestAccAWSWafRule_disappears
=== CONT  TestAccAWSWafRule_disappears
--- PASS: TestAccAWSWafRule_disappears (52.29s)
=== RUN   TestAccAWSWafRule_changePredicates
=== PAUSE TestAccAWSWafRule_changePredicates
=== CONT  TestAccAWSWafRule_changePredicates
--- PASS: TestAccAWSWafRule_changePredicates (82.21s)
=== RUN   TestAccAWSWafRule_geoMatchSetPredicate
=== PAUSE TestAccAWSWafRule_geoMatchSetPredicate
=== CONT  TestAccAWSWafRule_geoMatchSetPredicate
--- PASS: TestAccAWSWafRule_geoMatchSetPredicate (54.37s)
=== RUN   TestAccAWSWafRule_noPredicates
=== PAUSE TestAccAWSWafRule_noPredicates
=== CONT  TestAccAWSWafRule_noPredicates
--- PASS: TestAccAWSWafRule_noPredicates (34.87s)
=== RUN   TestAccAWSWafRule_Tags
=== PAUSE TestAccAWSWafRule_Tags
=== CONT  TestAccAWSWafRule_Tags
--- PASS: TestAccAWSWafRule_Tags (114.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	180.696s

...

This completes some things missed in #10408 + added ARN attribute and Create Function Calls read instead of update

[bflad]

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSWafRule_disappears (37.44s)
--- PASS: TestAccAWSWafRule_changeNameForceNew (78.08s)
--- PASS: TestAccAWSWafRule_Tags (97.69s)
--- PASS: TestAccAWSWafRule_basic (109.39s)
--- PASS: TestAccAWSWafRule_noPredicates (120.43s)
--- PASS: TestAccAWSWafRule_changePredicates (137.63s)
--- PASS: TestAccAWSWafRule_geoMatchSetPredicate (171.14s)

[ghost]

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!