r/waf_rule_group - refactor to use keyvaluetags

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

- resource/resource_aws_waf_rule_group: Add `arn` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafRuleGroup_'
=== RUN   TestAccAWSWafRuleGroup_basic
=== PAUSE TestAccAWSWafRuleGroup_basic
=== CONT  TestAccAWSWafRuleGroup_basic
--- PASS: TestAccAWSWafRuleGroup_basic (56.97s)
=== RUN   TestAccAWSWafRuleGroup_changeNameForceNew
=== PAUSE TestAccAWSWafRuleGroup_changeNameForceNew
=== CONT  TestAccAWSWafRuleGroup_changeNameForceNew
--- PASS: TestAccAWSWafRuleGroup_changeNameForceNew (79.63s)
=== RUN   TestAccAWSWafRuleGroup_disappears
=== PAUSE TestAccAWSWafRuleGroup_disappears
=== CONT  TestAccAWSWafRuleGroup_disappears
--- PASS: TestAccAWSWafRuleGroup_disappears (48.51s)
=== RUN   TestAccAWSWafRuleGroup_changeActivatedRules
=== PAUSE TestAccAWSWafRuleGroup_changeActivatedRules
=== CONT  TestAccAWSWafRuleGroup_changeActivatedRules
--- PASS: TestAccAWSWafRuleGroup_changeActivatedRules (86.70s)
=== RUN   TestAccAWSWafRuleGroup_Tags
=== PAUSE TestAccAWSWafRuleGroup_Tags
=== CONT  TestAccAWSWafRuleGroup_Tags
--- PASS: TestAccAWSWafRuleGroup_Tags (86.59s)
=== RUN   TestAccAWSWafRuleGroup_noActivatedRules
=== PAUSE TestAccAWSWafRuleGroup_noActivatedRules
=== CONT  TestAccAWSWafRuleGroup_noActivatedRules
--- PASS: TestAccAWSWafRuleGroup_noActivatedRules (33.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	159.982s

...

This completes some things missed in #10408 + added ARN attribute and Create Function Calls read instead of update

[bflad]

LGTM, thanks @DrFaust92 🚀

--- PASS: TestAccAWSWafRuleGroup_noActivatedRules (19.50s)
--- PASS: TestAccAWSWafRuleGroup_basic (34.23s)
--- PASS: TestAccAWSWafRuleGroup_changeNameForceNew (40.88s)
--- PASS: TestAccAWSWafRuleGroup_Tags (41.96s)
--- PASS: TestAccAWSWafRuleGroup_disappears (59.83s)
--- PASS: TestAccAWSWafRuleGroup_changeActivatedRules (75.38s)

[ghost]

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!