r/waf_web_acl - refactor to use keyvaluetags

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

- resource/resource_aws_waf_wb_acl: Add `arn` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafWebAcl_'
=== RUN   TestAccAWSWafWebAcl_basic
=== PAUSE TestAccAWSWafWebAcl_basic
=== CONT  TestAccAWSWafWebAcl_basic
--- PASS: TestAccAWSWafWebAcl_basic (43.23s)
=== RUN   TestAccAWSWafWebAcl_changeNameForceNew
=== PAUSE TestAccAWSWafWebAcl_changeNameForceNew
=== CONT  TestAccAWSWafWebAcl_changeNameForceNew
--- PASS: TestAccAWSWafWebAcl_changeNameForceNew (68.48s)
=== RUN   TestAccAWSWafWebAcl_DefaultAction
=== PAUSE TestAccAWSWafWebAcl_DefaultAction
=== CONT  TestAccAWSWafWebAcl_DefaultAction
--- PASS: TestAccAWSWafWebAcl_DefaultAction (60.55s)
=== RUN   TestAccAWSWafWebAcl_Rules
=== PAUSE TestAccAWSWafWebAcl_Rules
=== CONT  TestAccAWSWafWebAcl_Rules
--- FAIL: TestAccAWSWafWebAcl_Rules (115.69s)
    testing.go:615: Step 2 error: errors during apply:
        
        Error: Error deleting WAF Rule: WAFReferencedItemException: This entity is still referenced by other entities.
        	status code: 400, request id: 7b8d2082-0235-11ea-9c2f-bff495d1e256
        
        
=== RUN   TestAccAWSWafWebAcl_LoggingConfiguration
=== PAUSE TestAccAWSWafWebAcl_LoggingConfiguration
=== CONT  TestAccAWSWafWebAcl_LoggingConfiguration
--- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (226.53s)
=== RUN   TestAccAWSWafWebAcl_disappears
=== PAUSE TestAccAWSWafWebAcl_disappears
=== CONT  TestAccAWSWafWebAcl_disappears
--- PASS: TestAccAWSWafWebAcl_disappears (28.45s)
=== RUN   TestAccAWSWafWebAcl_Tags
=== PAUSE TestAccAWSWafWebAcl_Tags
=== CONT  TestAccAWSWafWebAcl_Tags
--- PASS: TestAccAWSWafWebAcl_Tags (85.95s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	235.060s

...

[bflad]

LGTM, thanks @DrFaust92 🚀

Output from acceptance testing (failure unrelated):

--- PASS: TestAccAWSWafWebAcl_disappears (12.41s)
--- PASS: TestAccAWSWafWebAcl_basic (16.78s)
--- PASS: TestAccAWSWafWebAcl_DefaultAction (27.95s)
--- PASS: TestAccAWSWafWebAcl_Tags (42.49s)
--- PASS: TestAccAWSWafWebAcl_changeNameForceNew (51.29s)
--- FAIL: TestAccAWSWafWebAcl_Rules (61.07s)
--- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (109.63s)

[ghost]

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!