Feature/refactor tagging code to use keyvaluetags for aws sagemaker resources

[teraken0509]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

• aws_sagemaker_endpoint

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerEndpoint_'==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpoint_ -timeout 120m
=== RUN   TestAccAWSSagemakerEndpoint_basic
=== PAUSE TestAccAWSSagemakerEndpoint_basic
=== RUN   TestAccAWSSagemakerEndpoint_EndpointConfigName
=== PAUSE TestAccAWSSagemakerEndpoint_EndpointConfigName
=== RUN   TestAccAWSSagemakerEndpoint_Tags
=== PAUSE TestAccAWSSagemakerEndpoint_Tags
=== CONT  TestAccAWSSagemakerEndpoint_basic
=== CONT  TestAccAWSSagemakerEndpoint_Tags
=== CONT  TestAccAWSSagemakerEndpoint_EndpointConfigName
--- PASS: TestAccAWSSagemakerEndpoint_basic (545.61s)
--- PASS: TestAccAWSSagemakerEndpoint_Tags (653.84s)
--- PASS: TestAccAWSSagemakerEndpoint_EndpointConfigName (1135.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1135.759s

• aws_sagemaker_endpoint_configuration

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpointConfiguration_ -timeout 120m
=== RUN   TestAccAWSSagemakerEndpointConfiguration_Basic
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_Basic
=== RUN   TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_InitialVariantWeight
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_InitialVariantWeight
=== RUN   TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_AcceleratorType
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_AcceleratorType
=== RUN   TestAccAWSSagemakerEndpointConfiguration_KmsKeyId
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_KmsKeyId
=== RUN   TestAccAWSSagemakerEndpointConfiguration_Tags
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_Tags
=== CONT  TestAccAWSSagemakerEndpointConfiguration_Basic
=== CONT  TestAccAWSSagemakerEndpointConfiguration_KmsKeyId
=== CONT  TestAccAWSSagemakerEndpointConfiguration_Tags
=== CONT  TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_AcceleratorType
=== CONT  TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_InitialVariantWeight
--- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_InitialVariantWeight (56.66s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_Basic (72.78s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_AcceleratorType (75.24s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_Tags (85.86s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_KmsKeyId (103.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	103.082s

• aws_sagemaker_model

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerModel_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerModel_ -timeout 120m
=== RUN   TestAccAWSSagemakerModel_basic
=== PAUSE TestAccAWSSagemakerModel_basic
=== RUN   TestAccAWSSagemakerModel_tags
=== PAUSE TestAccAWSSagemakerModel_tags
=== RUN   TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== PAUSE TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== RUN   TestAccAWSSagemakerModel_primaryContainerHostname
=== PAUSE TestAccAWSSagemakerModel_primaryContainerHostname
=== RUN   TestAccAWSSagemakerModel_primaryContainerEnvironment
=== PAUSE TestAccAWSSagemakerModel_primaryContainerEnvironment
=== RUN   TestAccAWSSagemakerModel_containers
=== PAUSE TestAccAWSSagemakerModel_containers
=== RUN   TestAccAWSSagemakerModel_vpcConfig
=== PAUSE TestAccAWSSagemakerModel_vpcConfig
=== RUN   TestAccAWSSagemakerModel_networkIsolation
=== PAUSE TestAccAWSSagemakerModel_networkIsolation
=== CONT  TestAccAWSSagemakerModel_basic
=== CONT  TestAccAWSSagemakerModel_primaryContainerEnvironment
=== CONT  TestAccAWSSagemakerModel_networkIsolation
=== CONT  TestAccAWSSagemakerModel_vpcConfig
=== CONT  TestAccAWSSagemakerModel_containers
=== CONT  TestAccAWSSagemakerModel_primaryContainerModelDataUrl
=== CONT  TestAccAWSSagemakerModel_primaryContainerHostname
=== CONT  TestAccAWSSagemakerModel_tags
--- PASS: TestAccAWSSagemakerModel_containers (52.44s)
--- PASS: TestAccAWSSagemakerModel_networkIsolation (55.37s)
--- PASS: TestAccAWSSagemakerModel_basic (63.34s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (68.45s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (70.60s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (78.13s)
--- PASS: TestAccAWSSagemakerModel_tags (82.80s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (86.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.613s

• aws_sagemaker_noteboo_instance

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_update
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (342.21s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (348.06s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (353.14s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (436.02s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (793.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	793.529s

[bflad]

LGTM, thanks @kterada0509 🚀

--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Basic (13.09s)
--- PASS: TestAccAWSSagemakerNotebookInstanceLifecycleConfiguration_Update (17.58s)
--- PASS: TestAccAWSSagemakerModel_vpcConfig (28.38s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerEnvironment (32.37s)
--- PASS: TestAccAWSSagemakerModel_tags (38.38s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerModelDataUrl (57.25s)
--- PASS: TestAccAWSSagemakerModel_networkIsolation (58.30s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_KmsKeyId (66.96s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_InitialVariantWeight (69.81s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_Basic (72.72s)
--- PASS: TestAccAWSSagemakerModel_containers (80.18s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_ProductionVariants_AcceleratorType (83.74s)
--- PASS: TestAccAWSSagemakerModel_primaryContainerHostname (84.47s)
--- PASS: TestAccAWSSagemakerModel_basic (87.51s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (281.64s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (298.15s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (304.80s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (309.15s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (556.12s)
--- PASS: TestAccAWSSagemakerEndpoint_Tags (585.78s)
--- PASS: TestAccAWSSagemakerEndpoint_basic (593.07s)
--- PASS: TestAccAWSSagemakerEndpoint_EndpointConfigName (991.56s)

[bflad]

Good catch 😄

[ghost]

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!