-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stale issue closer behavior #10839
Conversation
.hashibot.hcl
Outdated
@@ -11,6 +11,20 @@ poll "closed_issue_locker" "locker" { | |||
EOF | |||
} | |||
|
|||
poll "stale_issue_closer" "closer" { | |||
schedule = "0 50 12 * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a brittle aspect of the system 🙈, I'd like to avoid polls all waking at this same time (to clarify other providers have pasted around similar configs and I think a few happen at 12:50 now), let's pick some new arbitrary point in the day, say 3:10? 0 10 3 * * *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine, updated
.hashibot.hcl
Outdated
no_reply_in_last = "2160h" # 90 days | ||
max_issues = 500 | ||
sleep_between_issues = "5s" | ||
created_after = "2019-11-11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain on why we only want to consider issues after today, but that is outside the context of the review, I'm sure this was very intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some concerns about inflicting this on people who might have other expectations -- I'll ping the rest of the team to make sure we couldn't go earlier.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Adding HashiBot stale issue behavior: close after 90 days, starting with issues created today.
Release note for CHANGELOG:
Output from acceptance testing: