Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale issue closer behavior #10839

Merged
merged 3 commits into from
Nov 18, 2019
Merged

Add stale issue closer behavior #10839

merged 3 commits into from
Nov 18, 2019

Conversation

aeschright
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Adding HashiBot stale issue behavior: close after 90 days, starting with issues created today.

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@aeschright aeschright added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 11, 2019
@aeschright aeschright requested review from appilon and a team November 11, 2019 22:13
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Nov 11, 2019
.hashibot.hcl Outdated
@@ -11,6 +11,20 @@ poll "closed_issue_locker" "locker" {
EOF
}

poll "stale_issue_closer" "closer" {
schedule = "0 50 12 * * *"
Copy link
Contributor

@appilon appilon Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a brittle aspect of the system 🙈, I'd like to avoid polls all waking at this same time (to clarify other providers have pasted around similar configs and I think a few happen at 12:50 now), let's pick some new arbitrary point in the day, say 3:10? 0 10 3 * * *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine, updated

.hashibot.hcl Outdated
no_reply_in_last = "2160h" # 90 days
max_issues = 500
sleep_between_issues = "5s"
created_after = "2019-11-11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain on why we only want to consider issues after today, but that is outside the context of the review, I'm sure this was very intentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some concerns about inflicting this on people who might have other expectations -- I'll ping the rest of the team to make sure we couldn't go earlier.

@aeschright aeschright removed the needs-triage Waiting for first response or review from a maintainer. label Nov 12, 2019
@aeschright aeschright merged commit d91001b into master Nov 18, 2019
@aeschright aeschright deleted the td-stale-issues branch November 18, 2019 21:51
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants