refactor tagging code to use keyvaluetags for aws rds cluster resources

[teraken0509]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

• aws_rds_cluster_instance

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSClusterInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSClusterInstance_basic -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_basic
=== PAUSE TestAccAWSRDSClusterInstance_basic
=== CONT  TestAccAWSRDSClusterInstance_basic
--- PASS: TestAccAWSRDSClusterInstance_basic (1137.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1137.856s

• aws_rds_cluster_parameter_group

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBClusterParameterGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBClusterParameterGroup_ -timeout 120m
=== RUN   TestAccAWSDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDBClusterParameterGroup_basic
=== RUN   TestAccAWSDBClusterParameterGroup_withApplyMethod
=== PAUSE TestAccAWSDBClusterParameterGroup_withApplyMethod
=== RUN   TestAccAWSDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDBClusterParameterGroup_namePrefix_Parameter
=== PAUSE TestAccAWSDBClusterParameterGroup_namePrefix_Parameter
=== RUN   TestAccAWSDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDBClusterParameterGroup_generatedName_Parameter
=== PAUSE TestAccAWSDBClusterParameterGroup_generatedName_Parameter
=== RUN   TestAccAWSDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDBClusterParameterGroup_only
=== PAUSE TestAccAWSDBClusterParameterGroup_only
=== CONT  TestAccAWSDBClusterParameterGroup_basic
=== CONT  TestAccAWSDBClusterParameterGroup_generatedName_Parameter
=== CONT  TestAccAWSDBClusterParameterGroup_only
=== CONT  TestAccAWSDBClusterParameterGroup_disappears
=== CONT  TestAccAWSDBClusterParameterGroup_namePrefix_Parameter
=== CONT  TestAccAWSDBClusterParameterGroup_generatedName
=== CONT  TestAccAWSDBClusterParameterGroup_namePrefix
=== CONT  TestAccAWSDBClusterParameterGroup_withApplyMethod
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (29.47s)
--- PASS: TestAccAWSDBClusterParameterGroup_only (38.25s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (38.63s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (39.50s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (39.62s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (39.91s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (41.82s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (65.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	65.279s

[bflad]

LGTM, thanks @kterada0509 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRDSClusterInstance_az (752.61s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (776.40s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (786.45s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (13.46s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (793.22s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (8.18s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (8.15s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (8.30s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (8.04s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (8.20s)
--- PASS: TestAccAWSRDSClusterInstance_generatedName (806.96s)
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (6.27s)
--- PASS: TestAccAWSDBClusterParameterGroup_only (7.89s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (823.07s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (833.29s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (848.39s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (857.54s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (869.82s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (886.31s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (888.60s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (891.33s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (914.77s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (917.47s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (933.74s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (1008.81s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (1020.63s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1331.64s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1657.71s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (1012.91s)

[ghost]

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!