Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lambda_function: Expand kms_key_arn documentation and testing when no environment variables are present #10850

Merged

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 12, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6366
Reference: https://docs.aws.amazon.com/lambda/latest/dg/API_CreateFunction.html#SSS-CreateFunction-request-KMSKeyArn

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (56.91s)

…sting when no environment variables are present

Reference: #6366

Output from acceptance testing:

```
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (56.91s)
```
@bflad bflad requested a review from a team November 12, 2019 20:40
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 12, 2019
…SLambdaFunction_KmsKeyArn_NoEnvironmentVariables test comment
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 12, 2019
@bflad bflad added this to the v2.36.0 milestone Nov 12, 2019
@bflad bflad merged commit 2070567 into master Nov 12, 2019
@bflad bflad deleted the d-aws_lambda_function-kms_key_arn-no-environment-variables branch November 12, 2019 21:43
@ghost
Copy link

ghost commented Nov 14, 2019

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_lambda_function does not persist kms_key_arn unless at least one environment variable included
2 participants