Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glue workflow #10891

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Glue workflow #10891

merged 3 commits into from
Nov 19, 2019

Conversation

bdoepf
Copy link
Contributor

@bdoepf bdoepf commented Nov 15, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10116

Right now the Glue Crawler can't be used in the workflow graph. Probably the trigger's action must be extended by the 'crawler_name' field.

Release note for CHANGELOG:

resource/aws_glue_workflow: Add glue workflow resource
resource/aws_glue_trigger: Add 'workflow_name' attribute, add 'crawler_name' attribute to 'action'

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueWorkflow*'
=== RUN   TestAccAWSGlueWorkflow_Basic
=== PAUSE TestAccAWSGlueWorkflow_Basic
=== RUN   TestAccAWSGlueWorkflow_DefaultRunProperties
=== PAUSE TestAccAWSGlueWorkflow_DefaultRunProperties
=== RUN   TestAccAWSGlueWorkflow_Description
=== PAUSE TestAccAWSGlueWorkflow_Description
=== CONT  TestAccAWSGlueWorkflow_Basic
=== CONT  TestAccAWSGlueWorkflow_Description
=== CONT  TestAccAWSGlueWorkflow_DefaultRunProperties
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (29.23s)
--- PASS: TestAccAWSGlueWorkflow_Basic (29.39s)
--- PASS: TestAccAWSGlueWorkflow_Description (46.62s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       47.858s

$ make testacc TESTARGS='-run=TestAccAWSGlueTrigger*'
=== RUN   TestAccAWSGlueTrigger_Basic
=== PAUSE TestAccAWSGlueTrigger_Basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_Basic
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_Crawler
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_Description
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_Schedule
--- PASS: TestAccAWSGlueTrigger_WorkflowName (48.18s)
--- PASS: TestAccAWSGlueTrigger_Basic (56.47s)
--- PASS: TestAccAWSGlueTrigger_Crawler (66.11s)
--- PASS: TestAccAWSGlueTrigger_Description (67.95s)
--- PASS: TestAccAWSGlueTrigger_Predicate (98.46s)
--- PASS: TestAccAWSGlueTrigger_Schedule (104.25s)
--- PASS: TestAccAWSGlueTrigger_Enabled (132.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       133.497s

@bdoepf bdoepf requested a review from a team November 15, 2019 10:44
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Nov 15, 2019
@bdoepf
Copy link
Contributor Author

bdoepf commented Nov 16, 2019

Updated the PR. Now also Glue Crawlers can be used in Glue Workflows.

@bflad bflad added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2019
@bflad bflad self-assigned this Nov 19, 2019
@bflad
Copy link
Contributor

bflad commented Nov 19, 2019

This pull request overlaps #9762 and #10190 for the aws_glue_trigger updates -- I am going to try to merge each of these in order (addressing review feedback) to preserve the earlier contributions.

@bflad bflad added this to the v2.39.0 milestone Nov 19, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdoepf 🚀

Output from acceptance testing (after fixing up complex merge):

--- PASS: TestAccAWSGlueTrigger_WorkflowName (30.76s)
--- PASS: TestAccAWSGlueTrigger_Basic (50.13s)
--- PASS: TestAccAWSGlueTrigger_Description (54.13s)
--- PASS: TestAccAWSGlueTrigger_Predicate (65.53s)
--- PASS: TestAccAWSGlueTrigger_Schedule (79.04s)
--- PASS: TestAccAWSGlueTrigger_Crawler (85.59s)
--- PASS: TestAccAWSGlueTrigger_Enabled (117.36s)

--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (13.18s)
--- PASS: TestAccAWSGlueWorkflow_Basic (13.70s)
--- PASS: TestAccAWSGlueWorkflow_Description (20.63s)

bflad added a commit that referenced this pull request Nov 19, 2019
… complex merge and review feedback

Reference: #9762
Reference: #10190
Reference: #10891

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueTrigger_WorkflowName (30.76s)
--- PASS: TestAccAWSGlueTrigger_Basic (50.13s)
--- PASS: TestAccAWSGlueTrigger_Description (54.13s)
--- PASS: TestAccAWSGlueTrigger_Predicate (65.53s)
--- PASS: TestAccAWSGlueTrigger_Schedule (79.04s)
--- PASS: TestAccAWSGlueTrigger_Crawler (85.59s)
--- PASS: TestAccAWSGlueTrigger_Enabled (117.36s)
```
@bflad bflad merged commit db039f3 into hashicorp:master Nov 19, 2019
bflad added a commit that referenced this pull request Nov 19, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for AWS Glue Workflows
2 participants