Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tagging code to use keyvaluetags for aws msk resources & data source #10907

Merged
merged 3 commits into from
Nov 25, 2019
Merged

refactor tagging code to use keyvaluetags for aws msk resources & data source #10907

merged 3 commits into from
Nov 25, 2019
+11 −212

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 18, 2019
@bflad
Copy link
Contributor

bflad commented Nov 21, 2019

Hi @kterada0509 👋 Is this pull request in draft mode just due to the failing acceptance tests (also present on master, due to #10673)? The refactoring here looks okay.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 21, 2019
@teraken0509
Copy link
Contributor Author

Hi @kterada0509 👋 Is this pull request in draft mode just due to the failing acceptance tests (also present on master, due to #10673)? The refactoring here looks okay.

Yes, I trying to fix acceptance test.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 23, 2019
@teraken0509 teraken0509 force-pushed the feature/refactor-tagging-code-to-use-keyvaluetags-for-aws_msk-resources branch from f1e93c3 to ccf7ebb Compare November 23, 2019 08:14
@teraken0509 teraken0509 marked this pull request as ready for review November 23, 2019 08:14
@teraken0509 teraken0509 requested a review from a team November 23, 2019 08:14
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 25, 2019
@bflad bflad added this to the v2.40.0 milestone Nov 25, 2019
bflad
bflad approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kterada0509 🚀 We can treat the API default change as part of the other issue. 👍

@bflad bflad merged commit 4a4d5ef into hashicorp:master Nov 25, 2019
@teraken0509 teraken0509 deleted the feature/refactor-tagging-code-to-use-keyvaluetags-for-aws_msk-resources branch November 26, 2019 04:37
@ghost
Copy link

ghost commented Nov 27, 2019

This has been released in version 2.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/kafka Issues and PRs that pertain to the kafka service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@teraken0509 @bflad