Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_rds_cluster: Allow enable/disable Data API Aurora Serverless #11048

Merged
merged 3 commits into from
Jan 14, 2020
Merged

r/aws_rds_cluster: Allow enable/disable Data API Aurora Serverless #11048

merged 3 commits into from
Jan 14, 2020

Conversation

awsiv
Copy link
Contributor

@awsiv awsiv commented Nov 27, 2019 •
edited by gdavison
Loading

Add option to enable Data API for aurora serverless

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10026

Release note for CHANGELOG:

resource/aws_rds_cluster: Allow enable/disable Aurora Serverless HTTP endpoint (Data API) with `enable_http_endpoint`

Output from acceptance testing:

± make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSCluster_EnableHttpEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSCluster_EnableHttpEndpoint -timeout 120m
=== RUN   TestAccAWSRDSCluster_EnableHttpEndpoint
=== PAUSE TestAccAWSRDSCluster_EnableHttpEndpoint
=== CONT  TestAccAWSRDSCluster_EnableHttpEndpoint
--- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (388.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	388.525s
...

@awsiv awsiv requested a review from a team November 27, 2019 23:58
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 27, 2019
@awsiv awsiv mentioned this pull request Nov 28, 2019
Closed
@gmunguia gmunguia mentioned this pull request Nov 28, 2019
Closed
@gdavison
Copy link
Contributor

gdavison commented Jan 7, 2020 •
edited
Loading

Thanks for this PR, @awsiv. We try to keep our parameters named consistently with the AWS API parameters, even when the API name could be improved :) Could you rename data_api_enabled to enable_http_endpoint, please?

@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Jan 7, 2020
@gdavison gdavison self-assigned this Jan 7, 2020
@awsiv
Copy link
Contributor Author

awsiv commented Jan 11, 2020

@gdavison thanks for the review!

Agree with you on naming consistency :). Have updated the PR, please take a look.

I think the http endpoint enables additional possibilities for database management for RDS. eg, we could implement the functionalities provided by postgres/mysql terraform provider over the data api, within the terraform-aws provider itself. Something I've been playing around with here: https://github.com/awsiv/terraform-provider-rdsdataservice

gdavison
gdavison approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSRDSClusterInstance_generatedName (613.21s)
--- PASS: TestAccAWSRDSClusterInstance_CopyTagsToSnapshot (717.58s)
--- PASS: TestAccAWSRDSClusterInstance_PubliclyAccessible (738.01s)
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (756.50s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraPostgresql (771.70s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2 (802.45s)
--- PASS: TestAccAWSRDSClusterInstance_isAlreadyBeingDeleted (803.42s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_RemovedToEnabled (807.66s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1 (822.04s)
--- PASS: TestAccAWSRDSClusterInstance_az (853.95s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql1 (859.10s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql1_DefaultKeyToCustomKey (876.72s)
--- PASS: TestAccAWSRDSClusterInstance_disappears (878.13s)
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (3.49s)
--- PASS: TestAccAWSRDSCluster_basic (119.57s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsEnabled_AuroraMysql2 (912.17s)
--- PASS: TestAccAWSRDSCluster_AvailabilityZones (120.63s)
--- PASS: TestAccAWSRDSCluster_ClusterIdentifierPrefix (119.40s)
--- PASS: TestAccAWSRDSClusterInstance_kmsKey (932.87s)
--- PASS: TestAccAWSRDSCluster_DbSubnetGroupName (123.78s)
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (144.91s)
--- PASS: TestAccAWSRDSCluster_generatedName (129.86s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (130.25s)
--- PASS: TestAccAWSRDSCluster_Tags (130.82s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToDisabled (1027.88s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (115.95s)
--- PASS: TestAccAWSRDSCluster_encrypted (109.41s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringRoleArn_EnabledToRemoved (1056.51s)
--- PASS: TestAccAWSRDSCluster_kmsKey (148.75s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (144.77s)
--- PASS: TestAccAWSRDSCluster_copyTagsToSnapshot (180.03s)
--- PASS: TestAccAWSRDSCluster_iamAuth (129.62s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (144.52s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Multimaster (123.66s)
--- PASS: TestAccAWSRDSClusterEndpoint_basic (1155.66s)
--- PASS: TestAccAWSRDSCluster_EngineMode_Global (129.80s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (139.67s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (122.05s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier (124.09s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports (327.50s)
--- SKIP: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Serverless (0.00s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Remove (118.26s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Add (124.54s)
--- PASS: TestAccAWSRDSClusterInstance_MonitoringInterval (1237.70s)
--- PASS: TestAccAWSRDSCluster_GlobalClusterIdentifier_Update (129.47s)
--- FAIL: TestAccAWSRDSCluster_EngineMode (279.74s) pre-existing failure
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraMysql2_DefaultKeyToCustomKey (774.20s)
--- PASS: TestAccAWSRDSCluster_Port (277.44s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql_DefaultKeyToCustomKey (739.55s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (327.14s)
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (742.29s)
--- PASS: TestAccAWSRDSClusterInstance_PerformanceInsightsKmsKeyId_AuroraPostgresql (786.29s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (349.20s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (362.97s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (377.02s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (336.96s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (358.28s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (357.22s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterPassword (357.25s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_MasterUsername (357.15s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (377.46s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (367.75s)
--- PASS: TestAccAWSRDSClusterInstance_basic (1680.84s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (327.49s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (318.24s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (317.49s)
--- PASS: TestAccAWSRDSCluster_EnableHttpEndpoint (308.26s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (645.45s)
--- FAIL: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1100.28s) pre-existing failure
--- FAIL: TestAccAWSRDSCluster_s3Restore (1501.87s) pre-existing failure
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1770.16s)

@gdavison gdavison merged commit 87faba7 into hashicorp:master Jan 14, 2020
@gdavison gdavison mentioned this pull request Jan 14, 2020
Closed
@gdavison gdavison added this to the v2.45.0 milestone Jan 14, 2020
@gdavison gdavison removed their assignment Jan 14, 2020
gdavison added a commit that referenced this pull request Jan 14, 2020
@gdavison
Update CHANGELOG for #11048
32b7f17
@ghost
Copy link

ghost commented Jan 17, 2020

This has been released in version 2.45.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@michaelgmcd michaelgmcd mentioned this pull request Mar 20, 2020
Merged
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.45.0
Development

Successfully merging this pull request may close these issues.

Support EnableHttpEndpoint for aws_rds_cluster
2 participants
@awsiv @gdavison