resource/default_network_acl: Add support for ipv6_cidr_block #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #1096 default_security_group already has support for ipv6_cidr_block. ``` % make testacc TEST=./aws TESTARGS='-run=TestAccAWSDefaultNetworkAcl_withIpv6Ingress' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -run=TestAccAWSDefaultNetworkAcl_withIpv6Ingress -timeout 120m === RUN TestAccAWSDefaultNetworkAcl_withIpv6Ingress --- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (53.45s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 53.511s ```
stack72
added
the
enhancement
Ninir
approved these changes
Jul 11, 2017
There was a problem hiding this comment.
LGTM!
Just saw a failing test, but seems not related to this specifically:
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDefaultNetworkAcl_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDefaultNetworkAcl_ -timeout 120m
=== RUN TestAccAWSDefaultNetworkAcl_basic
--- PASS: TestAccAWSDefaultNetworkAcl_basic (18.77s)
=== RUN TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- FAIL: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (13.95s)
testing.go:428: Step 0 error: Error applying: 1 error(s) occurred:
* aws_vpc.tftestvpc: 1 error(s) occurred:
* aws_vpc.tftestvpc: AuthFailure: This request has been administratively disabled.
status code: 403, request id: d8d82b6a-0570-4ba2-9c91-f8cbdafa322c
testing.go:492: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: Error refreshing: 1 error(s) occurred:
* aws_vpc.tftestvpc: 1 error(s) occurred:
* aws_vpc.tftestvpc: aws_vpc.tftestvpc: AuthFailure: This request has been administratively disabled.
status code: 403, request id: 87b003e3-fc13-4d6b-9fba-c662638c5e7a
State: <nil>
=== RUN TestAccAWSDefaultNetworkAcl_deny_ingress
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (16.68s)
=== RUN TestAccAWSDefaultNetworkAcl_withIpv6Ingress
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (17.83s)
=== RUN TestAccAWSDefaultNetworkAcl_SubnetRemoval
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (33.45s)
=== RUN TestAccAWSDefaultNetworkAcl_SubnetReassign
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (35.84s)
|
@stack72 if this is already supported by aws_default_security_group, the docs will also need an update too. Otherwise, given my limited knowledge of the terraform code, this LGTM too. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1096
default_security_group already has support for ipv6_cidr_block.