[WIP] Add Resource aws_ec2_transit_gateway_peering_attachment_accepter #11185

j-nix · 2019-12-06T19:40:06Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #11117

Release note for CHANGELOG:

New Resource: aws_ec2_transit_gateway_peering_attachment_accepter (#11185)

Output from acceptance testing:
Tests still outstanding

$ make testacc TESTARGS='-run=TestAccXXX'

...

Update and Delete functions implemented to interact with the AWS GO SDK for transit gateway peering attachments acceptance waitFor functions added for Delete terraform operations. Describe function added for transit gateway peering attachments acceptance.

Create and read functions implemented to interact with the AWS GO SDK for transit gateway peering attachment acceptance. waitFor functions added for Create/Read terraform operations & acceptance. Add provider resource mapping to provider.go

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

Move `waitForEc2TransitGatewayPeeringAttachmentAcceptance` into the correct place.

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

Default route table propogation doesn't appear to be supported by transit gateway peering attachments, only an assocation to the default route table is supported - removed references to propogation. Co-authored-by: Omarimcblack 43746683+Omarimcblack@users.noreply.github.com

ewbankkit · 2020-01-16T23:18:17Z

@j-nix @Omarimcblack Let me know if you need any help with testing this.

erikkn · 2020-01-30T13:34:04Z

Hey, guys :)! Wondering if there is any timeline of getting this PR (and #11162) in master, perhaps in the next release already 🙊 ?

emalihin · 2020-02-20T11:19:55Z

Hey @j-nix , thanks for your contribution! Looking to use this as soon as we can, do you need any help with this and #11162 ?

zenvdeluca · 2020-04-08T13:47:54Z

if serves as an encouragement, AWS now supports inter-region peering in ALL regions 🍾

https://aws.amazon.com/about-aws/whats-new/2020/04/aws-transit-gateway-now-supports-inter-region-peering-in-11-additional-regions/

bflad

Hi @j-nix 👋 Thank you for starting this. I have left some initial feedback on the provided code.

Please also note that:

This code will require rebase after merge of Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162 for likely merge conflicts
Acceptance testing will need to be added. Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162 has some great examples that can serve as the base for this resource's testing. Please see the New Resource section of the Contributing Guide for more information and especially the cross-account/cross-region testing setup
Documentation will need to be added, including adding this resource to website/aws.erb and creating a new documentation page at website/docs/r/ec2_transit_gateway_peering_attachment_accepter.html.markdown

Please reach out if you have any questions or do not have time to implement the items.

aws/resource_aws_ec2_transit_gateway_peering_attachment_accepter.go

j-nix · 2020-04-27T09:44:47Z

Hi @bflad ! Thanks a lot for leaving the comments here, I'm going to take a look at them and finish this PR off shortly as there's still a bit of work to be done here 👍

Tagging now handled by shared `keyvaluetags` package Co-Authored-By: Brian Flad <bflad417@gmail.com>

Fixes peer transit gateway/local transit gateway information to be the correct object. Co-Authored-By: Brian Flad <bflad417@gmail.com>

…ry items Default route table assocation is not necessary, this was copied from the attachment resource accidentally Co-Authored-By: Brian Flad <bflad417@gmail.com>

… aws_ec2_transit_gateway_peering_attachment (hashicorp#11162) Output from acceptance testing: ``` --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (279.30s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (274.76s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (298.80s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (341.73s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (290.68s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (281.60s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (291.70s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (308.69s) ```

…ent_accepter

bflad · 2020-05-01T17:12:17Z

Drive-by note: The resource implementation is looking really good! The CI failure is due to us adding and enforcing provider-wide ignore tags functionality as of a few days ago -- two line fix:

// In the Read function, near the conn := 
ignoreTagsConfig := meta.(*AWSClient).IgnoreTagsConfig

// In the d.Set("tags", ...) call
d.Set("tags", keyvaluetags.Ec2KeyValueTags(transitGatewayPeeringAttachment.Tags).IgnoreAws().IgnoreConfig(ignoreTagsConfig).Map())

Hope this helps. 😄 Please reach out when this is ready for review.

j-nix · 2020-05-01T23:59:47Z

Hi @bflad thanks for the help with the CI failure that should be pushed up now - very helpful!

The tests are almost finished - will reach out by the end of the weekendwhen completed 👍

bflad · 2020-05-07T17:58:19Z

Hi @j-nix 👋 Any chance you could push up the testing you have (even incomplete)? We'd love to release this today if we can!

j-nix · 2020-05-07T18:13:04Z

Hi @bflad , I've just pushed the tests up however they are still incomplete and have a little bit of work to do - I appreciate you want to get this out asap to go with the peering attachment resource!

Apoloigies for the wait on this - sadly we haven't been able to find the time to complete them yet!

bflad

Great work, @j-nix! The testing was really close -- just a few minor tweaks and it was good to go. Thanks again for working through this tougher one! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_sameAccount (625.85s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_differentAccount (628.47s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_Tags_sameAccount (630.60s)

zenvdeluca · 2020-05-08T00:27:57Z

the end-user community certainly appreciates all the work put in here. cheers!

ghost · 2020-05-08T01:47:23Z

This has been released in version 2.61.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-06-07T17:10:37Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Omarimcblack and others added 2 commits December 6, 2019 19:18

j-nix requested a review from a team December 6, 2019 19:40

j-nix pushed a commit to j-nix/terraform-provider-aws that referenced this pull request Dec 6, 2019

Remove references to tgw peering attachment acceptance

54b21e5

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

Fix conflicts

475d5b1

Move `waitForEc2TransitGatewayPeeringAttachmentAcceptance` into the correct place.

Omarimcblack pushed a commit to j-nix/terraform-provider-aws that referenced this pull request Dec 7, 2019

Remove references to tgw peering attachment acceptance

a37f145

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

ewbankkit mentioned this pull request Dec 17, 2019

Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162

Merged

acarrasquillo mentioned this pull request Jan 9, 2020

Inter-region peering for Transit Gateways #11117

Closed

ewbankkit mentioned this pull request Jan 16, 2020

aws_ram_resource_share_accepter wanting to create again #10064

Closed

bflad added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 16, 2020

bflad self-assigned this Apr 17, 2020

bflad suggested changes Apr 17, 2020

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 17, 2020

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 27, 2020

j-nix and others added 3 commits April 27, 2020 16:48

aws_ec2_transit_gateway_peering_attachment_accepter: keyvaluetags

0d1dee0

Tagging now handled by shared `keyvaluetags` package Co-Authored-By: Brian Flad <bflad417@gmail.com>

aws_ec2_transit_gateway_peering_attachment_accepter: peer tgw direction

14d7328

Fixes peer transit gateway/local transit gateway information to be the correct object. Co-Authored-By: Brian Flad <bflad417@gmail.com>

aws_ec2_transit_gateway_peering_attachment_accepter: remove unnecessa…

e3341ca

…ry items Default route table assocation is not necessary, this was copied from the attachment resource accidentally Co-Authored-By: Brian Flad <bflad417@gmail.com>

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 27, 2020

Omarimcblack force-pushed the om_aws_ec2_transit_gateway_peering_attachment_accepter branch from 41e56ac to 9ad7bbf Compare May 1, 2020 15:45

Omarimcblack force-pushed the om_aws_ec2_transit_gateway_peering_attachment_accepter branch from 9ad7bbf to 4cee185 Compare May 1, 2020 15:56

Merge branch 'master' into om_aws_ec2_transit_gateway_peering_attachm…

f4a7331

…ent_accepter

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels May 1, 2020

bflad added this to the v2.61.0 milestone May 1, 2020

bflad linked an issue May 1, 2020 that may be closed by this pull request

Inter-region peering for Transit Gateways #11117

Closed

Joe Horner added 2 commits May 2, 2020 00:45

Add docs for transit gateway peering attachment accepter

c5570aa

Implement ignore-tags functionality

d54dc11

j-nix force-pushed the om_aws_ec2_transit_gateway_peering_attachment_accepter branch from c74c3bf to d54dc11 Compare May 1, 2020 23:58

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label May 1, 2020

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 5, 2020

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 7, 2020

Initial commit for tests - WIP

9d69509

j-nix force-pushed the om_aws_ec2_transit_gateway_peering_attachment_accepter branch from c312715 to 9d69509 Compare May 7, 2020 18:11

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label May 7, 2020

bflad approved these changes May 8, 2020

View reviewed changes

bflad added a commit that referenced this pull request May 8, 2020

Update CHANGELOG for #11185

9676e33

bflad merged commit 98efe4b into hashicorp:master May 8, 2020

ghost locked and limited conversation to collaborators Jun 7, 2020

j-nix deleted the om_aws_ec2_transit_gateway_peering_attachment_accepter branch February 25, 2021 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add Resource aws_ec2_transit_gateway_peering_attachment_accepter #11185

[WIP] Add Resource aws_ec2_transit_gateway_peering_attachment_accepter #11185

j-nix commented Dec 6, 2019 •

edited

Loading

ewbankkit commented Jan 16, 2020

erikkn commented Jan 30, 2020

emalihin commented Feb 20, 2020

zenvdeluca commented Apr 8, 2020

bflad left a comment •

edited

Loading

j-nix commented Apr 27, 2020 •

edited

Loading

bflad commented May 1, 2020

j-nix commented May 1, 2020

bflad commented May 7, 2020

j-nix commented May 7, 2020 •

edited

Loading

bflad left a comment

zenvdeluca commented May 8, 2020

ghost commented May 8, 2020

ghost commented Jun 7, 2020

[WIP] Add Resource aws_ec2_transit_gateway_peering_attachment_accepter #11185

[WIP] Add Resource aws_ec2_transit_gateway_peering_attachment_accepter #11185

Conversation

j-nix commented Dec 6, 2019 • edited Loading

Community Note

ewbankkit commented Jan 16, 2020

erikkn commented Jan 30, 2020

emalihin commented Feb 20, 2020

zenvdeluca commented Apr 8, 2020

bflad left a comment • edited Loading

Choose a reason for hiding this comment

j-nix commented Apr 27, 2020 • edited Loading

bflad commented May 1, 2020

j-nix commented May 1, 2020

bflad commented May 7, 2020

j-nix commented May 7, 2020 • edited Loading

bflad left a comment

Choose a reason for hiding this comment

zenvdeluca commented May 8, 2020

ghost commented May 8, 2020

ghost commented Jun 7, 2020

j-nix commented Dec 6, 2019 •

edited

Loading

bflad left a comment •

edited

Loading

j-nix commented Apr 27, 2020 •

edited

Loading

j-nix commented May 7, 2020 •

edited

Loading