Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_emr_cluster: Implements step_concurrency_level #11196

Merged

Conversation

artburkart
Copy link
Contributor

@artburkart artburkart commented Dec 8, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11159

Release note for CHANGELOG:

* resource/aws_emr_cluster: Support step concurrency level

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEMRCluster_step_concurrency_level'

--- PASS: TestAccAWSEMRCluster_step_concurrency_level (538.64s)

@artburkart artburkart requested a review from a team December 8, 2019 13:27
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/emr Issues and PRs that pertain to the emr service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 8, 2019
    * Please vote on this pull request by adding a +1 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original pull request comment to help the community and maintainers prioritize this request

    * Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes hashicorp#11159

Release note for [CHANGELOG](https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md):

```md
* resource/aws_emr_cluster: Support step concurrency level
```

Output from acceptance testing:

```
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (538.64s)
```
@artburkart artburkart force-pushed the f-aws_emr_cluster-step_concurrency_level branch from f3a633f to bfaf44f Compare December 8, 2019 13:34
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @artburkart 👋 Thank you for submitting this. Overall its looking pretty good, although we likely either need to add a default for the attribute or set Computed: true so that it does not break existing Terraform configurations (which you can verify running some of the other tests).

Please reach out if you have any questions or do not have time to implement the fixes here. 👍

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 9, 2019
@artburkart
Copy link
Contributor Author

I'll add a default of 1, since that's the AWS default. I thought I'd done that, but I must've spaced it after all 😅

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 9, 2019
@artburkart
Copy link
Contributor Author

@bflad - I've pushed up the new commit.
I remember why I didn't try out the other acceptance tests. Some of them can't execute right out of the box. They require the creation of some special IAM roles specific to the tests. Because I was struggling with this, I sort of called it quits once I got one acceptance test to run.

@bflad bflad added this to the v2.42.0 milestone Dec 10, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @artburkart 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEMRCluster_additionalInfo (457.86s)
--- PASS: TestAccAWSEMRCluster_basic (407.26s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (601.60s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (376.77s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (567.85s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1104.28s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (703.25s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (884.62s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_CoreInstanceType (555.23s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_InstanceGroup (614.94s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (852.99s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (494.94s)
--- PASS: TestAccAWSEMRCluster_disappears (747.52s)
--- PASS: TestAccAWSEMRCluster_instance_group (515.59s)
--- PASS: TestAccAWSEMRCluster_instance_group_EBSVolumeType_st1 (514.80s)
--- PASS: TestAccAWSEMRCluster_instance_group_names (605.60s)
--- PASS: TestAccAWSEMRCluster_instance_group_update (629.70s)
--- PASS: TestAccAWSEMRCluster_keepJob (428.19s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (495.32s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (1117.48s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1101.00s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (926.97s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_InstanceGroup (455.96s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_MasterInstanceType (442.83s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (1045.65s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (729.73s)
--- PASS: TestAccAWSEMRCluster_s3Logging (595.12s)
--- PASS: TestAccAWSEMRCluster_security_config (443.21s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (451.61s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (452.49s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (817.49s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (530.66s)
--- PASS: TestAccAWSEMRCluster_tags (809.48s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (607.56s)
--- PASS: TestAccAWSEMRCluster_updateAutoScalingPolicy (534.95s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (969.03s)

@bflad bflad merged commit b04e725 into hashicorp:master Dec 10, 2019
bflad added a commit that referenced this pull request Dec 10, 2019
@ghost
Copy link

ghost commented Dec 13, 2019

This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@artburkart artburkart deleted the f-aws_emr_cluster-step_concurrency_level branch December 13, 2019 22:24
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StepConcurrencyLevel for EMR
2 participants