-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_emr_cluster: Implements step_concurrency_level #11196
resource/aws_emr_cluster: Implements step_concurrency_level #11196
Conversation
* Please vote on this pull request by adding a +1 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original pull request comment to help the community and maintainers prioritize this request * Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request Closes hashicorp#11159 Release note for [CHANGELOG](https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md): ```md * resource/aws_emr_cluster: Support step concurrency level ``` Output from acceptance testing: ``` --- PASS: TestAccAWSEMRCluster_step_concurrency_level (538.64s) ```
f3a633f
to
bfaf44f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @artburkart 👋 Thank you for submitting this. Overall its looking pretty good, although we likely either need to add a default for the attribute or set Computed: true
so that it does not break existing Terraform configurations (which you can verify running some of the other tests).
Please reach out if you have any questions or do not have time to implement the fixes here. 👍
I'll add a default of |
@bflad - I've pushed up the new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @artburkart 🚀
Output from acceptance testing:
--- PASS: TestAccAWSEMRCluster_additionalInfo (457.86s)
--- PASS: TestAccAWSEMRCluster_basic (407.26s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (601.60s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (376.77s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (567.85s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1104.28s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (703.25s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (884.62s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_CoreInstanceType (555.23s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Migration_InstanceGroup (614.94s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (852.99s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (494.94s)
--- PASS: TestAccAWSEMRCluster_disappears (747.52s)
--- PASS: TestAccAWSEMRCluster_instance_group (515.59s)
--- PASS: TestAccAWSEMRCluster_instance_group_EBSVolumeType_st1 (514.80s)
--- PASS: TestAccAWSEMRCluster_instance_group_names (605.60s)
--- PASS: TestAccAWSEMRCluster_instance_group_update (629.70s)
--- PASS: TestAccAWSEMRCluster_keepJob (428.19s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (495.32s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (1117.48s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1101.00s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (926.97s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_InstanceGroup (455.96s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Migration_MasterInstanceType (442.83s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (1045.65s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (729.73s)
--- PASS: TestAccAWSEMRCluster_s3Logging (595.12s)
--- PASS: TestAccAWSEMRCluster_security_config (443.21s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (451.61s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (452.49s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (817.49s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (530.66s)
--- PASS: TestAccAWSEMRCluster_tags (809.48s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (607.56s)
--- PASS: TestAccAWSEMRCluster_updateAutoScalingPolicy (534.95s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (969.03s)
This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #11159
Release note for CHANGELOG:
Output from acceptance testing: