-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CodePipeline pipeline and webhook resources to use keyvaluetags package and fix webhook resource recreation issues #11387
Conversation
|
…figuration configuration block attribute values change.
7483e9a
to
6ed08b4
Compare
"tags": { | ||
Type: schema.TypeMap, | ||
Optional: true, | ||
ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to recreate resource when tags
change.
@@ -43,11 +44,13 @@ func resourceAwsCodePipelineWebhook() *schema.Resource { | |||
"secret_token": { | |||
Type: schema.TypeString, | |||
Optional: true, | |||
ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recreate resource when secret_token
changes.
Sensitive: true, | ||
}, | ||
"allowed_ip_range": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recreate resource when allowed_ip_range
changes.
Removed WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for these updates, @ewbankkit 🚀
Output from acceptance testing:
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (23.53s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (25.98s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (29.60s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (32.22s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (38.70s)
--- PASS: TestAccAWSCodePipeline_tags (43.93s)
--- PASS: TestAccAWSCodePipeline_basic (49.31s)
--- PASS: TestAccAWSCodePipelineWebhook_basic (49.84s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (56.36s)
This has been released in version 2.45.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #8017.
Relates #10688.
Release note for CHANGELOG:
Output from acceptance testing: