-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_api_gateway_usage_plan_key: Support resource import #11439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this, @DrFaust92 -- the implementation here is off to a good start. 😄 Rather than burdening operators to provide the key type during import, it looks like we should be properly performing drift detection of the attribute by setting it in the Terraform state in the Read
function. This will remove the import ID requirement. Please reach out if you have any questions or do not have time to implement the feedback.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @DrFaust92! 🚀
Output from acceptance testing:
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_disappears (21.37s)
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (106.97s)
This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #558
Release note for CHANGELOG:
Output from acceptance testing: