Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Resource Names are not a valid option #11446

Conversation

ItsKarma
Copy link
Contributor

@ItsKarma ItsKarma commented Dec 31, 2019

Amazon Resource Names (ARNs) are not a valid option, only the short name of the resource is valid. See the aws cli documentation example.

--capacity-providers (list)
The name of one or more capacity providers to associate with the cluster.

Here is also a link to the direct API Reference

capacityProviders
The name of one or more capacity providers to associate with the cluster.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11338

Release note for CHANGELOG:

NONE

Output from acceptance testing:

NONE - Documentation update.

@ItsKarma ItsKarma requested a review from a team December 31, 2019 19:36
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. documentation Introduces or discusses updates to documentation. labels Dec 31, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this, @ItsKarma 🚀 Interestingly, the CreateCluster API reference includes the ARN mention while the PutClusterCapacityProviders API reference does not. We test only using the name, so let's remove the ARN mention from our documentation for now.

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 2, 2020
@bflad bflad added this to the v2.44.0 milestone Jan 2, 2020
@bflad bflad merged commit 7ba42b7 into hashicorp:master Jan 2, 2020
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating Capacity Providers on ECS Cluster
4 participants