resource/aws_appautoscaling_policy: Remove unimplemented alarms attribute #11494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute Reference: #9954 Previously: ``` /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_appautoscaling_policy.go:333:18: R004: ResourceData.Set() incompatible value type: []*github.com/aws/aws-sdk-go/service/applicationautoscaling.Alarm ``` The `alarms` attribute was never actually implemented: - `d.Set()` never would have set anything in the Terraform state due to silently ignoring the error above, so Terraform configuration references to the attribute would always have been invalid trying to reference a non-existent resource attribute - Configuring `alarms` in a configuration was never valid as it would not have done anything (CloudWatch Alarms are a read-only property of Application Auto Scaling Policies) - Not acceptance tested - Not documented Due to these conditions and since there are no associated bug reports or feature requests for this attribute, it feels safe to bypass our normal attribute deprecation/removal process and just remove the errant attribute definition from the schema. If desired in the future, this could be implemented as a `Computed: true` only attribute. Output from acceptance testing: ``` --- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (34.67s) --- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (40.33s) --- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (41.44s) --- PASS: TestAccAWSAppautoScalingPolicy_disappears (72.83s) --- PASS: TestAccAWSAppautoScalingPolicy_basic (78.93s) --- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (81.81s) --- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (87.53s) --- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (88.80s) ```
bflad
added
the
technical-debt
ghost
added
size/XS
bflad
removed
the
needs-triage
ryndaniels
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
--- PASS: TestValidateAppautoscalingPolicyImportInput (0.00s)
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (18.33s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (20.16s)
--- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (20.89s)
--- PASS: TestAccAWSAppautoScalingPolicy_basic (46.60s)
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (60.94s)
--- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (61.40s)
--- PASS: TestAccAWSAppautoScalingPolicy_disappears (65.26s)
--- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (70.00s)
|
This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #9954
Release note for CHANGELOG:
Previously:
The
alarmsattribute was never actually implemented:d.Set()never would have set anything in the Terraform state due to silently ignoring the error above, so Terraform configuration references to the attribute would always have been invalid trying to reference a non-existent resource attributealarmsin a configuration was never valid as it would not have done anything (CloudWatch Alarms are a read-only property of Application Auto Scaling Policies)Due to these conditions and since there are no associated bug reports or feature requests for this attribute, it feels safe to bypass our normal attribute deprecation/removal process and just remove the errant attribute definition from the schema. If desired in the future, this could be implemented as a
Computed: trueonly attribute.Output from acceptance testing: