Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure "FROM email address" for Cognito user pool (aws_cognito_user_pool) #11607

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Configure "FROM email address" for Cognito user pool (aws_cognito_user_pool) #11607

merged 3 commits into from
Mar 17, 2020

Conversation

jonas-pietzsch
Copy link
Contributor

@jonas-pietzsch jonas-pietzsch commented Jan 15, 2020

An AWS Cognito User Pool can be configured to use a custom "FROM email address" (see General Settings > Message customizations > FROM email address).
In the CreateUserPool and UpdateUserPool API reference the path to this field is "EmailConfiguration.From".
The value may contain email sender strings such as John Smith or John Smith <john@smith.com>.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11507

Release note for CHANGELOG:

* resource/aws_cognito_user_pool: Add `from_email_address` to `email_configuration`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TODO
...

@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/cognito tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 15, 2020
@jonas-pietzsch
Copy link
Contributor Author

Since today I can confirm that this is working for updating an existing aws_cognito_user_pool with the email address. No attempts to delete and re-create the pool were done either.

Output from acceptance tests will be handed in within the next days.

@jonas-pietzsch jonas-pietzsch marked this pull request as ready for review January 16, 2020 09:08
@jonas-pietzsch jonas-pietzsch requested a review from a team January 16, 2020 09:08
@bacoboy
Copy link

bacoboy commented Feb 19, 2020

Can we get a review on this please? Looks like it has been waiting a month. Thanks! 👋

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 21, 2020
@bflad bflad self-assigned this Feb 21, 2020
@Ninjadeer
Copy link

Is there any chance we can get this prodded, its been almost another month since the last review was requested and it seems to have stalled on travis although the link seesm to indicate all the checks were successful?

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jverhoelen 👋 Can you please rebase this pull request? Otherwise it is looking pretty good from scanning the changes. Thanks!

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 17, 2020
@jonas-pietzsch
Copy link
Contributor Author

Hey @bflad
it has just been rebased.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 17, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks so much, @jverhoelen 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCognitoUserPool_basic (15.19s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (57.33s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (47.43s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (30.47s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (28.24s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (40.94s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (21.42s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (51.45s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (56.24s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (51.32s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (22.61s)
--- PASS: TestAccAWSCognitoUserPool_update (43.47s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (25.65s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (14.56s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (27.01s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (28.80s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (23.96s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (20.43s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (44.34s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (17.84s)
--- PASS: TestAccAWSCognitoUserPool_withSchemaAttributes (17.15s)
--- PASS: TestAccAWSCognitoUserPool_withTags (29.88s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (24.30s)

@bflad bflad added this to the v2.54.0 milestone Mar 17, 2020
@bflad bflad merged commit 9116bd6 into hashicorp:master Mar 17, 2020
bflad added a commit that referenced this pull request Mar 17, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure "FROM email address" for Cognito user pool (aws_cognito_user_pool)
4 participants