-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure "FROM email address" for Cognito user pool (aws_cognito_user_pool) #11607
Configure "FROM email address" for Cognito user pool (aws_cognito_user_pool) #11607
Conversation
Since today I can confirm that this is working for updating an existing Output from acceptance tests will be handed in within the next days. |
Can we get a review on this please? Looks like it has been waiting a month. Thanks! 👋 |
Is there any chance we can get this prodded, its been almost another month since the last review was requested and it seems to have stalled on travis although the link seesm to indicate all the checks were successful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jverhoelen 👋 Can you please rebase this pull request? Otherwise it is looking pretty good from scanning the changes. Thanks!
…om terraform within 'cognito_user_pool' resource
Hey @bflad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks so much, @jverhoelen 🚀
Output from acceptance testing:
--- PASS: TestAccAWSCognitoUserPool_basic (15.19s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (57.33s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (47.43s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (30.47s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (28.24s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (40.94s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (21.42s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (51.45s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (56.24s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (51.32s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (22.61s)
--- PASS: TestAccAWSCognitoUserPool_update (43.47s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (25.65s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (14.56s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (27.01s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (28.80s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (23.96s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (20.43s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (44.34s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (17.84s)
--- PASS: TestAccAWSCognitoUserPool_withSchemaAttributes (17.15s)
--- PASS: TestAccAWSCognitoUserPool_withTags (29.88s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (24.30s)
This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
An AWS Cognito User Pool can be configured to use a custom "FROM email address" (see General Settings > Message customizations > FROM email address).
In the CreateUserPool and UpdateUserPool API reference the path to this field is "EmailConfiguration.From".
The value may contain email sender strings such as
John Smith
orJohn Smith <john@smith.com>
.Community Note
Closes #11507
Release note for CHANGELOG:
Output from acceptance testing: