Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_efs_file_system - add attributes #11647

Merged
merged 1 commit into from
Jan 24, 2020
Merged

d/aws_efs_file_system - add attributes #11647

merged 1 commit into from
Jan 24, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

data_source_aws_efs_file_system: add `throughput_mode`, `provisioned_throughput_in_mibps`, and  `lifecycle_policy` attributes.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsEfsFileSystem_'
--- PASS: TestAccDataSourceAwsEfsFileSystem_id (82.64s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (81.08s)
...

@DrFaust92
add throughput_mode, provisioned_throughput_in_mibps, and `lifecy…
fb034f1 
…cle_policy`.

refactor tests
remove call to list tags api
@DrFaust92 DrFaust92 requested a review from a team January 17, 2020 21:03
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 17, 2020
@DrFaust92 DrFaust92 changed the title [WIP]d/aws_efs_file_system - add attributes d/aws_efs_file_system - add attributes Jan 17, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 24, 2020
@bflad bflad self-assigned this Jan 24, 2020
bflad
bflad approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor documentation fixes on merge. Thanks, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsEfsFileSystem_id (16.28s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (16.30s)

website/docs/d/efs_file_system.html.markdown
@@ -40,3 +41,9 @@ In addition to all arguments above, the following attributes are exported:
* `encrypted` - Whether EFS is encrypted.
* `kms_key_id` - The ARN for the KMS encryption key.
* `dns_name` - The DNS name for the filesystem per [documented convention](http://docs.aws.amazon.com/efs/latest/ug/mounting-fs-mount-cmd-dns-name.html).
* `lifecycle_policy` - A file system [lifecycle policy](https://docs.aws.amazon.com/efs/latest/ug/API_LifecyclePolicy.html) object.
* `performance_mode` - The file system performance mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performance_mode was already declared on line 39 😄 will fix on merge.

website/docs/d/efs_file_system.html.markdown
* `lifecycle_policy` - A file system [lifecycle policy](https://docs.aws.amazon.com/efs/latest/ug/API_LifecyclePolicy.html) object.
* `performance_mode` - The file system performance mode.
* `provisioned_throughput_in_mibps` - The throughput, measured in MiB/s, that you want to provision for the file system.
* `tags` -A mapping of tags to assign to the file system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tags was already declared on line 40, will fix on merge.

@bflad bflad added this to the v2.47.0 milestone Jan 24, 2020
@bflad bflad merged commit edebc20 into hashicorp:master Jan 24, 2020
bflad added a commit that referenced this pull request Jan 24, 2020
@bflad
Update CHANGELOG for #11647
3b83218
@DrFaust92 DrFaust92 deleted the d/efs-file-sys branch January 24, 2020 16:27
@ghost
Copy link

ghost commented Jan 30, 2020

This has been released in version 2.47.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @bflad