Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_appautoscaling_target: Automatically retry creation on ValidationException: ECS service doesn't exist for ECS eventual consistency #11693

Merged
merged 1 commit into from
Feb 3, 2020
Merged

resource/aws_appautoscaling_target: Automatically retry creation on ValidationException: ECS service doesn't exist for ECS eventual consistency #11693

merged 1 commit into from
Feb 3, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_appautoscaling_target: Automatically retry creation on `ValidationException: ECS service doesn't exist` for ECS eventual consistency

Previously in the acceptance testing:

--- FAIL: TestAccAWSAppautoscalingScheduledAction_ECS (40.50s)
    testing.go:635: Step 0 error: errors during apply:

        Error: Error creating application autoscaling target: ValidationException: ECS service doesn't exist: service/tf-ecs-cluster-g2sk8/tf-ecs-service-g2sk8

Output from acceptance testing:

--- PASS: TestAccAWSAppautoscalingScheduledAction_ECS (60.14s)

--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (27.27s)
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (28.99s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (75.41s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (84.45s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (440.42s)

@bflad
resource/aws_appautoscaling_scheduled_action: Automatically retry cre…
f007de2 
…ation on `ValidationException: ECS service doesn't exist` for ECS eventual consistency

Previously in the acceptance testing:

```
--- FAIL: TestAccAWSAppautoscalingScheduledAction_ECS (40.50s)
    testing.go:635: Step 0 error: errors during apply:

        Error: Error creating application autoscaling target: ValidationException: ECS service doesn't exist: service/tf-ecs-cluster-g2sk8/tf-ecs-service-g2sk8
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAppautoscalingScheduledAction_ECS (60.14s)

--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (27.27s)
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (28.99s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (75.41s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (84.45s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (440.42s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Jan 21, 2020
@bflad bflad requested a review from a team January 21, 2020 18:49
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/applicationautoscaling labels Jan 21, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 21, 2020
gdavison
gdavison approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (16.29s)
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (18.56s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (60.00s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (70.73s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (816.98s)

@bflad bflad added this to the v2.48.0 milestone Feb 3, 2020
@bflad bflad merged commit 9dc1e42 into master Feb 3, 2020
@bflad bflad deleted the t-aws_appautoscaling_scheduled_action-ecs-eventual-consistency branch February 3, 2020 20:23
bflad added a commit that referenced this pull request Feb 3, 2020
@bflad
Update CHANGELOG for #11693
d4a63f3
@ghost
Copy link

ghost commented Feb 7, 2020

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @gdavison