Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message wording to reflect change in AWS API #11735

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

finferflu
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11711

Release note for CHANGELOG:

Fix  "BadRequestException" error while updating an API Gateway account.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayAccount'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayAccount -timeout 120m
=== RUN   TestAccAWSAPIGatewayAccount_basic
=== PAUSE TestAccAWSAPIGatewayAccount_basic
=== CONT  TestAccAWSAPIGatewayAccount_basic
--- PASS: TestAccAWSAPIGatewayAccount_basic (102.99s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       107.050s

@finferflu finferflu requested a review from a team January 23, 2020 16:06
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR. labels Jan 23, 2020
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 23, 2020
@bflad bflad added this to the v2.46.0 milestone Jan 23, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @finferflu 🚀 This will also fix the following daily acceptance testing failure:

--- FAIL: TestAccAWSAPIGatewayAccount_basic (7.69s)
    testing.go:640: Step 0 error: errors during apply:
        
        Error: Updating API Gateway Account failed: BadRequestException: The role ARN does not have required permissions configured. Please grant trust permission for API Gateway and add the required role policy.

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayAccount_basic (96.49s)

@bflad bflad merged commit 2d12be9 into hashicorp:master Jan 23, 2020
bflad added a commit that referenced this pull request Jan 23, 2020
@finferflu finferflu deleted the 11711-fix-api-gw-account-setup branch January 23, 2020 17:04
@ghost
Copy link

ghost commented Jan 23, 2020

This has been released in version 2.46.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apparent race condition while updating the API Gateway account
2 participants