Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/mq_configuration - add import tests + remove call to list tags #11843

Merged
merged 2 commits into from
Mar 25, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_mq_configuration: add plan time validation to `engine_type`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMqConfiguration_'
--- PASS: TestAccAWSMqConfiguration_basic (66.84s)
--- PASS: TestAccAWSMqConfiguration_withData (41.95s)
--- PASS: TestAccAWSMqConfiguration_updateTags (97.18s)

test arn
remove call to list tags
@DrFaust92 DrFaust92 requested a review from a team January 31, 2020 21:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/mq Issues and PRs that pertain to the mq service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 31, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 24, 2020
@bflad bflad self-assigned this Mar 24, 2020
@bflad bflad added this to the v2.55.0 milestone Mar 25, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks so much, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSMqConfiguration_withData (14.44s)
--- PASS: TestAccAWSMqConfiguration_basic (16.08s)
--- PASS: TestAccAWSMqConfiguration_updateTags (28.40s)

@bflad bflad merged commit d55da06 into hashicorp:master Mar 25, 2020
bflad added a commit that referenced this pull request Mar 25, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.55.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mq Issues and PRs that pertain to the mq service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants