New Resource: aws_lambda_layer_version_permission

[Avolynsk]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8595

Release note for CHANGELOG:

* **New Resource:** `aws_lambda_layer_version_permission`

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaLayerVersionPermission'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaLayerVersionPermission -timeout 120m
=== RUN   TestAccAWSLambdaLayerVersionPermission_all
=== PAUSE TestAccAWSLambdaLayerVersionPermission_all
=== RUN   TestAccAWSLambdaLayerVersionPermission_org
=== PAUSE TestAccAWSLambdaLayerVersionPermission_org
=== RUN   TestAccAWSLambdaLayerVersionPermission_account
=== PAUSE TestAccAWSLambdaLayerVersionPermission_account
=== RUN   TestAccAWSLambdaLayerVersionPermission_disappears
=== PAUSE TestAccAWSLambdaLayerVersionPermission_disappears
=== CONT  TestAccAWSLambdaLayerVersionPermission_all
=== CONT  TestAccAWSLambdaLayerVersionPermission_disappears
=== CONT  TestAccAWSLambdaLayerVersionPermission_account
=== CONT  TestAccAWSLambdaLayerVersionPermission_org
    TestAccAWSLambdaLayerVersionPermission_disappears: resource_aws_lambda_layer_version_permission_test.go:160: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSLambdaLayerVersionPermission_disappears (45.52s)
--- PASS: TestAccAWSLambdaLayerVersionPermission_all (53.67s)
--- PASS: TestAccAWSLambdaLayerVersionPermission_org (53.70s)
--- PASS: TestAccAWSLambdaLayerVersionPermission_account (53.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.582s

[Avolynsk]

WIP, will add tests soon.

[CliffHoogervorst]

When is this expected to be merged??

[Avolynsk]

@bflad could you pls take a look? Sorry for bothering you, just wondering if I've missed some contributing rules for my PR

[CliffHoogervorst]

@bflad can you please check ??

[DrFaust92]

some minor changes.

can you add the disappears test based on https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md#disappears-acceptance-tests

[Jorge-Rodriguez]

@Avolynsk @DrFaust92 do you have an estimate on how much more work/time would it take for this PR to be merged?

[sunilkumarmohanty]

This PR has not been updated for 6 months now. Should we create a duplicate PR with the changes?
pinging @bflad

[teamterraform]

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

[Jorge-Rodriguez]

@maryelizbeth @bflad @gdavison @anGie44 @breathingdust @ksatirli
Any news on this PR? @sunilkumarmohanty seems willing to get it up to snuff if necessary.
Personally, I would like to see this merged soon.

[bflad]

@Jorge-Rodriguez if there is no response from the original contributor, @Avolynsk, the maintainers will recommend a new pull request be submitted that contains changes on top of this one. It cannot be merged as-is.

[Avolynsk]

Hi guys! Sorry for the delay, I'll try to update the PR next week.

[sunilkumarmohanty]

Thanks @Avolynsk . However, if you are busy, please let me know. I can help with finishing the PR.

[Avolynsk]

hi @DrFaust92 ! I've fixed all things suggested by you during the review. The only thing that I'm not sure about is disappears test, could you pls take a look?

And during my work, I've merged an actual master branch into my own to get make build/tests works again, and seems this is causing CHANGELOG Checks / Comment (pull_request) check failure. Also, I've noticed that now my PR shows too many changed files, so now I don't know how to figure this out.
Could you pls help me with this?

[unix-system]

I can't see the issue with the PR that caused the test fail - perhaps rerun the test?

Keen for this to get merged, as it's a blocker for me. Let me know if you could use any help to push it over the line 🙂

[anGie44]

Thanks so much for this PR @Avolynsk 🚀 Overall, this looked great! I added in some changes to account for the service packages refactor.

Output of acceptance tests:

--- PASS: TestAccLambdaLayerVersionPermission_org (24.77s)
--- PASS: TestAccLambdaLayerVersionPermission_basic_byARN (29.05s)
--- PASS: TestAccLambdaLayerVersionPermission_disappears (30.18s)
--- PASS: TestAccLambdaLayerVersionPermission_basic_byName (34.84s)
--- PASS: TestAccLambdaLayerVersionPermission_account (37.62s)

[Jorge-Rodriguez]

LGTM

[github-actions]

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.