Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat(resource_vpc_flow_log): added max_aggregation_interval field #12007

Closed
wants to merge 1 commit into from
Closed

[WIP] feat(resource_vpc_flow_log): added max_aggregation_interval field #12007

wants to merge 1 commit into from

Conversation

ajorpheus
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11927

Release note for CHANGELOG:

This PR depends on aws sdk to be v1.28.10

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ajorpheus ajorpheus requested a review from a team February 12, 2020 14:15
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. labels Feb 12, 2020
@ajorpheus
Copy link
Author

ajorpheus commented Feb 12, 2020 •
edited
Loading

TODO:

  • Add Acceptance test(s)
  • Separate out aws-sdk-go upgrade to a separate PR (Not needed anymore after rebasing on latest upstream)

@bflad bflad removed the dependencies Used to indicate dependency changes. label Mar 6, 2020
@ewbankkit
Copy link
Contributor

@ajorpheus Thanks for working on this.
Will you have time to address the TODOs? I have interest in using this functionality and can help out/complete.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 17, 2020
@ewbankkit ewbankkit mentioned this pull request Mar 19, 2020
Merged
@ewbankkit
Copy link
Contributor

ewbankkit commented Mar 19, 2020 •
edited
Loading

@ajorpheus I opened another PR including your commit to add the acceptance tests: #12483. Thanks.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 19, 2020
@ajorpheus
Copy link
Author

@ewbankkit : Thank you for adding the required acc. tests.

@ajorpheus ajorpheus closed this Mar 24, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amazon VPC Flow Logs now support 1-minute aggregation intervals
3 participants
@ajorpheus @ewbankkit @bflad