Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port support for client vpn endpoint #12104

Closed
wants to merge 4 commits into from
Closed

port support for client vpn endpoint #12104

wants to merge 4 commits into from

Conversation

ranga543
Copy link
Contributor

@ranga543 ranga543 commented Feb 20, 2020 •
edited
Loading

Changes proposed in this pull request:

  • Added vpn_port to aws_ec2_client_vpn_endpoint resource.

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAwsEc2ClientVpnEndpoint_vpnPort'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAwsEc2ClientVpnEndpoint_vpnPort -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsEc2ClientVpnEndpoint_vpnPort
=== PAUSE TestAccAwsEc2ClientVpnEndpoint_vpnPort
=== CONT  TestAccAwsEc2ClientVpnEndpoint_vpnPort
--- PASS: TestAccAwsEc2ClientVpnEndpoint_vpnPort (41.28s)

Closes #11633

@ranga543 ranga543 requested a review from a team February 20, 2020 16:30
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 20, 2020
@e-moshaya
Copy link

can this be merged please?

@DrFaust92
Copy link
Collaborator

Closes #11633

gdavison
gdavison requested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ranga543, thanks for the PR! It looks great.

We've been doing some work on Client VPN resources, so there have been some changes, especially to the tests. The PR will need to be rebased, and then I have a few minor suggested changes.

aws/resource_aws_ec2_client_vpn_endpoint_test.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_client_vpn_endpoint_test.go Outdated Show resolved Hide resolved
aws/resource_aws_ec2_client_vpn_endpoint_test.go Outdated Show resolved Hide resolved
website/docs/r/ec2_client_vpn_endpoint.html.markdown Outdated Show resolved Hide resolved
@gdavison gdavison added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 10, 2020
@ranga543 ranga543 requested a review from gdavison July 14, 2020 15:02
@ranga543
Copy link
Contributor Author

@gdavison any status ?

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Aug 23, 2020
@DrFaust92
Copy link
Collaborator

Hey @ranga543 can you add Closes #11633 to you PR description. this way it will link the PR to the issue

@ranga543
Copy link
Contributor Author

@DrFaust92 just updated PR description to include closes.

@ranga543
Copy link
Contributor Author

@DrFaust92 any status ?

Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@russmac
Copy link

russmac commented Mar 12, 2021

@ranga543 Firstly thanks for your work on this 💯 Could you resolve the outstanding question? (It appears its resolved just not clicked resolved) #12104 (comment)

It might be causing this PR to be filtered out by Hashicorp. 👍

@ranga543
Copy link
Contributor Author

@russmac done.

@russmac
Copy link

russmac commented Mar 24, 2021

@gdavison Any requests for the PR author?

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

ewbankkit added a commit to thiagokiyota/terraform-provider-aws that referenced this pull request Jan 31, 2022
@ewbankkit
r/aws_client_vpn_endpoint: Add vpn_port argument (hashicorp#12104).
0ad29fd 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short -timeout 180m
=== RUN   TestAccEC2ClientVPNEndpoint_serial
=== PAUSE TestAccEC2ClientVPNEndpoint_serial
=== CONT  TestAccEC2ClientVPNEndpoint_serial
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth
    client_vpn_endpoint_test.go:205: skipping long-running test in short mode
2022/01/30 19:08:06 [WARN] Notifying semaphore without Wait
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
    client_vpn_endpoint_test.go:241: skipping long-running test in short mode
2022/01/30 19:08:06 [WARN] Notifying semaphore without Wait
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
--- PASS: TestAccEC2ClientVPNEndpoint_serial (2.24s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth (0.00s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth (0.00s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears (23.40s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic (29.59s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal (39.17s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags (56.24s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup (57.26s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth (58.30s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate (68.19s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers (73.86s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService (75.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        81.118s
@ewbankkit ewbankkit mentioned this pull request Jan 31, 2022
Merged
@ewbankkit
Copy link
Contributor

Superseded by #22793.

@ewbankkit
Copy link
Contributor

@ranga543 Thanks for the contribution 🎉 👏.
I have incorporated your changes into #22793.

@ewbankkit ewbankkit closed this Jan 31, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison Awaiting requested review from gdavison

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Client VPN now supports port configuration
7 participants
@ranga543 @e-moshaya @DrFaust92 @russmac @zhelding @ewbankkit @gdavison