11510 supports setting private_dns_name on resource_aws_vpc_endpoint_…

[craigedmunds]

Fixes #11510 by passing through the optional private_dns_name through to the aws sdk PrivateDnsName parameter

[codezninja]

any idea on when this will be released?

[ewbankkit]

@craigedmunds Thanks for this.
Are you able to rebase and remove the merge conflict?

[craigedmunds]

Hi, comments addressed & rebased.

[ewbankkit]

@craigedmunds Thanks for the quick response.
Could you please run make website-lint-fix and commit the changes, to make Travis happy.

[craigedmunds]

That’s done @ewbankkit

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointService_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointService_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointService_basic
=== PAUSE TestAccAWSVpcEndpointService_basic
=== RUN   TestAccAWSVpcEndpointService_PrivateDnsName
=== PAUSE TestAccAWSVpcEndpointService_PrivateDnsName
=== RUN   TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
=== PAUSE TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
=== RUN   TestAccAWSVpcEndpointService_removed
=== PAUSE TestAccAWSVpcEndpointService_removed
=== CONT  TestAccAWSVpcEndpointService_basic
=== CONT  TestAccAWSVpcEndpointService_removed
--- PASS: TestAccAWSVpcEndpointService_basic (279.31s)
=== CONT  TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
--- PASS: TestAccAWSVpcEndpointService_removed (321.97s)
=== CONT  TestAccAWSVpcEndpointService_PrivateDnsName
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (333.83s)
--- PASS: TestAccAWSVpcEndpointService_PrivateDnsName (296.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	618.216s

[craigedmunds]

Are you going to merge it @ewbankkit ?

[bayazee]

@craigedmunds I guess we should also add domain verification name and value support. Maybe as attributes?

[Mattias-]

Good job @craigedmunds thanks for helping out with this!

[kevholditch]

@craigedmunds I've fixed the merge conflict and submitted a PR to your repo. Thanks for the great work hoping to get this merged as need it for a project

[kevholditch]

@craigedmunds sorry my fix broke go fmt that is fixed now with another PR to your repo

[patcable]

Did a little digging to see if I could add the attributes for DNS record validation to @craigedmunds's fork; have a question over in #11510 on the "right way" to do this in TF

[nickelozz]

We're also needing private DNS name support in the VPC endpoint service resource. @ewbankkit are you able to provide any additional comments to identify what's missing to get this PR merged?

[bflad]

Hi @craigedmunds 👋 Thank you for submitting this. We have opted to pull in #16495, which includes the PrivateDnsNameConfiguration attributes that are returned from the EC2 API and is up to date without merge conflicts. This functionality will release with version 3.23.0 of the Terraform AWS Provider, later this week. 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!