r/aws_lightsail_instance: Fix crash when encountering key-only tags #12346

stefansundin · 2020-03-11T03:09:39Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes this crash:

panic: runtime error: invalid memory address or nil pointer dereference
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x44409fa]
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4:
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: goroutine 184 [running]:
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags.KeyValueTags.Map(0xc00082ff20, 0xc00082ff20)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags/key_value_tags.go:138 +0xda
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsLightsailInstanceRead(0xc000278e00, 0x51fa760, 0xc000180a00, 0xc000278e00, 0x0)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lightsail_instance.go:216 +0x6eb
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc000618200, 0xc000ff7c20, 0x51fa760, 0xc000180a00, 0xc00043cfb8, 0x0, 0x0)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/helper/schema/resource.go:455 +0x119
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin.(*GRPCProviderServer).ReadResource(0xc00043cb00, 0x6e58080, 0xc000995440, 0xc000ff7b30, 0xc00043cb00, 0xc000995440, 0xc000a40a80)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin/grpc_provider.go:525 +0x3d8
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5._Provider_ReadResource_Handler(0x635f2e0, 0xc00043cb00, 0x6e58080, 0xc000995440, 0xc000917ec0, 0x0, 0x6e58080, 0xc000995440, 0xc00098e380, 0x1bc)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5/tfplugin5.pb.go:3153 +0x217
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: google.golang.org/grpc.(*Server).processUnaryRPC(0xc0000d8000, 0x6e78cc0, 0xc000545e00, 0xc00092a200, 0xc0003c80f0, 0xa2400d0, 0x0, 0x0, 0x0)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:995 +0x460
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: google.golang.org/grpc.(*Server).handleStream(0xc0000d8000, 0x6e78cc0, 0xc000545e00, 0xc00092a200, 0x0)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:1275 +0xd97
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc0003b0800, 0xc0000d8000, 0x6e78cc0, 0xc000545e00, 0xc00092a200)
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:710 +0xbb
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: created by google.golang.org/grpc.(*Server).serveStreams.func1
2020-03-10T19:07:52.845-0700 [DEBUG] plugin.terraform-provider-aws_v2.52.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/vendor/google.golang.org/grpc/server.go:708 +0xa1

Creating tags with an empty string as a value appears to correctly create these key-only tags.

Documentation:

Release note for CHANGELOG:

resource/aws_lightsail_instance: Support key-only tags.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLightsailInstance_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLightsailInstance_Tags -timeout 120m
=== RUN   TestAccAWSLightsailInstance_Tags
=== PAUSE TestAccAWSLightsailInstance_Tags
=== CONT  TestAccAWSLightsailInstance_Tags
--- PASS: TestAccAWSLightsailInstance_Tags (80.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	82.636s

…Creating tags with an empty string as a value appears to correctly create these key-only tags.

ewbankkit · 2020-03-12T13:16:38Z

aws/internal/keyvaluetags/service_tags_gen.go

@@ -1782,7 +1782,13 @@ func LightsailKeyValueTags(tags []*lightsail.Tag) KeyValueTags {
 	m := make(map[string]*string, len(tags))

 	for _, tag := range tags {
-		m[aws.StringValue(tag.Key)] = tag.Value
+		if tag.Value == nil {


@stefansundin Thanks for this.
This source file is actually generated and will be recreated if make gen is run.
This behaviour may well be occurring for other AWS services (I will do some spot tests) so should be fixed globally.

https://github.com/terraform-providers/terraform-provider-aws/blob/654cc23a38444d4836155d6a2243e3976b5f3992/aws/internal/keyvaluetags/generators/servicetags/main.go#L256-L265

Ok. Updated. Let me know if I should make more changes.

ewbankkit · 2020-03-12T13:45:27Z

@stefansundin I opened an issue to track this.

Closes #12368.

stefansundin · 2020-03-21T03:22:17Z

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLightsailInstance_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLightsailInstance_Tags -timeout 120m
=== RUN   TestAccAWSLightsailInstance_Tags
=== PAUSE TestAccAWSLightsailInstance_Tags
=== CONT  TestAccAWSLightsailInstance_Tags
--- PASS: TestAccAWSLightsailInstance_Tags (80.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	82.636s

ewbankkit · 2020-03-21T21:24:36Z

Verified acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLightsailInstance_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLightsailInstance_Tags -timeout 120m
=== RUN   TestAccAWSLightsailInstance_Tags
=== PAUSE TestAccAWSLightsailInstance_Tags
=== CONT  TestAccAWSLightsailInstance_Tags
--- PASS: TestAccAWSLightsailInstance_Tags (70.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	70.117s

bflad · 2020-06-24T20:15:16Z

Hi @stefansundin 👋 Thank you for reporting this and sorry you ran into trouble here.

Rather than adjusting all of the generated service functions, we would prefer to fix the underlying (keyvaluetags.KeyValueTags).Map() panic as part some work we are doing to add support for Auto Scaling service tags: https://github.com/terraform-providers/terraform-provider-aws/pull/13868/files#diff-d536593b39c59c8af54d5145c3e6206eL180

If there are other services that are distinguishing between nil/"" we can revisit this type of change on a per-service level.

Can you adjust this pull request to just being the aws_lightsail_instance testing and documentation updates and we will use this to verify Lightsail key-only tagging is working as expected? Thank you.

stefansundin · 2020-06-25T01:03:06Z

@bflad Do you want me to pull in master?

Edit: Nevermind, I did.

This reverts commit b4814ae.

…form-provider-aws into lightsail-key-only-tag

bflad · 2020-06-25T13:45:08Z

@stefansundin thanks so much! I was able to verify this updated test passes after #13868.

--- PASS: TestAccAWSLightsailInstance_Tags (75.80s)

We should expect to see the fix land in the next week or so.

ghost · 2020-09-03T19:31:39Z

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-10-01T17:10:15Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

r/aws_lightsail_instance: Fix crash when encountering key-only tags. …

8129b77

…Creating tags with an empty string as a value appears to correctly create these key-only tags.

stefansundin requested a review from a team March 11, 2020 03:09

ewbankkit reviewed Mar 12, 2020

View reviewed changes

ewbankkit mentioned this pull request Mar 12, 2020

r/aws_lightsail_instance: Crash when adding tag with empty value #12368

Closed

bflad linked an issue Mar 13, 2020 that may be closed by this pull request

r/aws_lightsail_instance: Crash when adding tag with empty value #12368

Closed

bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 13, 2020

stefansundin added 2 commits March 20, 2020 20:09

Update generator.

b4814ae

Update wording.

bf4e3df

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 21, 2020

bflad self-assigned this Jun 24, 2020

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 24, 2020

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 25, 2020

stefansundin added 3 commits June 24, 2020 18:08

Revert "Update generator."

db14882

This reverts commit b4814ae.

make gen

1ef536d

Merge branch 'master' of https://github.com/terraform-providers/terra…

165592d

…form-provider-aws into lightsail-key-only-tag

ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jun 25, 2020

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:27

Merge branch 'master' into lightsail-key-only-tag

d3876d5

bflad added this to the v3.5.0 milestone Sep 1, 2020

bflad merged commit fcac15f into hashicorp:master Sep 1, 2020

ghost locked as resolved and limited conversation to collaborators Oct 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_lightsail_instance: Fix crash when encountering key-only tags #12346

r/aws_lightsail_instance: Fix crash when encountering key-only tags #12346

stefansundin commented Mar 11, 2020 •

edited

Loading

ewbankkit Mar 12, 2020 •

edited

Loading

stefansundin Mar 21, 2020

ewbankkit commented Mar 12, 2020

stefansundin commented Mar 21, 2020

ewbankkit commented Mar 21, 2020

bflad commented Jun 24, 2020

stefansundin commented Jun 25, 2020 •

edited

Loading

bflad commented Jun 25, 2020

ghost commented Sep 3, 2020

ghost commented Oct 1, 2020

r/aws_lightsail_instance: Fix crash when encountering key-only tags #12346

r/aws_lightsail_instance: Fix crash when encountering key-only tags #12346

Conversation

stefansundin commented Mar 11, 2020 • edited Loading

Community Note

ewbankkit Mar 12, 2020 • edited Loading

Choose a reason for hiding this comment

stefansundin Mar 21, 2020

Choose a reason for hiding this comment

ewbankkit commented Mar 12, 2020

stefansundin commented Mar 21, 2020

ewbankkit commented Mar 21, 2020

bflad commented Jun 24, 2020

stefansundin commented Jun 25, 2020 • edited Loading

bflad commented Jun 25, 2020

ghost commented Sep 3, 2020

ghost commented Oct 1, 2020

stefansundin commented Mar 11, 2020 •

edited

Loading

ewbankkit Mar 12, 2020 •

edited

Loading

stefansundin commented Jun 25, 2020 •

edited

Loading