Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cloudtrail - add support for insight selectors #12390

Merged
merged 5 commits into from
Sep 2, 2020
Merged

r/aws_cloudtrail - add support for insight selectors #12390

merged 5 commits into from
Sep 2, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10988

Release note for CHANGELOG:

resource_aws_cloudtrail - add support for insight selectors

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudTrail/Trail/insightSelector|TestAccAWSCloudTrail/Trail/basic'
        --- PASS: TestAccAWSCloudTrail/Trail/insightSelector (112.51s)
        --- PASS: TestAccAWSCloudTrail/Trail/basic (179.40s)

@DrFaust92 DrFaust92 requested a review from a team March 13, 2020 21:43
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 13, 2020
@omuthu-personal omuthu-personal mentioned this pull request May 4, 2020
Closed
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudTrail/Trail/insightSelector'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCloudTrail/Trail/insightSelector -timeout 120m
=== RUN   TestAccAWSCloudTrailServiceAccount_basic
=== PAUSE TestAccAWSCloudTrailServiceAccount_basic
=== RUN   TestAccAWSCloudTrailServiceAccount_Region
=== PAUSE TestAccAWSCloudTrailServiceAccount_Region
=== RUN   TestAccAWSCloudTrail
=== RUN   TestAccAWSCloudTrail/Trail
=== RUN   TestAccAWSCloudTrail/Trail/insightSelector
--- PASS: TestAccAWSCloudTrail (52.32s)
    --- PASS: TestAccAWSCloudTrail/Trail (52.32s)
        --- PASS: TestAccAWSCloudTrail/Trail/insightSelector (52.32s)
=== CONT  TestAccAWSCloudTrailServiceAccount_basic
=== CONT  TestAccAWSCloudTrailServiceAccount_Region
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (21.22s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (21.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	73.735s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudTrail/Trail/basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCloudTrail/Trail/basic -timeout 120m
=== RUN   TestAccAWSCloudTrailServiceAccount_basic
=== PAUSE TestAccAWSCloudTrailServiceAccount_basic
=== RUN   TestAccAWSCloudTrailServiceAccount_Region
=== PAUSE TestAccAWSCloudTrailServiceAccount_Region
=== RUN   TestAccAWSCloudTrail
=== RUN   TestAccAWSCloudTrail/Trail
=== RUN   TestAccAWSCloudTrail/Trail/basic
--- PASS: TestAccAWSCloudTrail (85.53s)
    --- PASS: TestAccAWSCloudTrail/Trail (85.53s)
        --- PASS: TestAccAWSCloudTrail/Trail/basic (85.52s)
=== CONT  TestAccAWSCloudTrailServiceAccount_basic
=== CONT  TestAccAWSCloudTrailServiceAccount_Region
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (21.27s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (21.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	106.903s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 25, 2020
@DrFaust92 DrFaust92 force-pushed the cloudtrail-insight-selector branch from 4d3929e to d25af6d Compare July 29, 2020 14:13
@bflad bflad self-assigned this Sep 2, 2020
bflad
bflad approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some minor fixes during merge. 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCloudTrail_serial (345.05s)
    --- PASS: TestAccAWSCloudTrail_serial/Trail (345.05s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/cloudwatch (56.41s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/enableLogging (37.83s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/isMultiRegion (39.66s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/logValidation (28.02s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/kmsKey (16.51s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/insightSelector (16.55s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/basic (26.48s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/includeGlobalServiceEvents (15.51s)
        --- SKIP: TestAccAWSCloudTrail_serial/Trail/isOrganization (1.04s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/tags (36.75s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelector (70.30s)

website/docs/r/cloudtrail.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cloudtrail.html.markdown Outdated Show resolved Hide resolved
aws/resource_aws_cloudtrail_test.go Outdated Show resolved Hide resolved
aws/resource_aws_cloudtrail.go Outdated Show resolved Hide resolved
aws/resource_aws_cloudtrail.go Outdated Show resolved Hide resolved
@bflad bflad added this to the v3.5.0 milestone Sep 2, 2020
@bflad bflad merged commit adb6b7a into hashicorp:master Sep 2, 2020
bflad added a commit that referenced this pull request Sep 2, 2020
@bflad
Update CHANGELOG for #12390
8dc192e
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2020
@DrFaust92 DrFaust92 deleted the cloudtrail-insight-selector branch November 23, 2021 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@enderbsd enderbsd enderbsd approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

AWS CloudTrail Insights
4 participants
@DrFaust92 @ewbankkit @bflad @enderbsd