Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_db_instance: Expose db_instance ca_cert_identifier #1256

Merged
merged 1 commit into from
Jul 31, 2017
Merged

resource/aws_db_instance: Expose db_instance ca_cert_identifier #1256

merged 1 commit into from
Jul 31, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 27, 2017

Fixes: #1166

Ninir
Ninir suggested changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Paul,

Just left a few comments regarding a typo and the actual existence of the attribute post-creation/update :)

Thanks for that! 👍

aws/data_source_aws_db_instance.go Outdated
@@ -277,6 +282,7 @@ func dataSourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error
d.Set("storage_type", dbInstance.StorageType)
d.Set("timezone", dbInstance.Timezone)
d.Set("replicate_source_db", dbInstance.ReadReplicaSourceDBInstanceIdentifier)
d.Set("replicate_source_db", dbInstance.CACertificateIdentifier)
Copy link
Contributor

@Ninir Ninir Jul 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here regarding the attribute name :)

aws/resource_aws_db_instance.go
@@ -828,6 +832,8 @@ func resourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error {

d.Set("replicate_source_db", v.ReadReplicaSourceDBInstanceIdentifier)

d.Set("ca_cert_identifier", v.CACertificateIdentifier)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also check in the acctest that the attribute is set?

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 28, 2017
@radeksimko radeksimko added waiting-response Maintainers are waiting on response from community or contributor. and removed waiting-response Maintainers are waiting on response from community or contributor. labels Jul 28, 2017
@stack72 stack72 force-pushed the b-aws-db-instance-cacert-1166 branch from 6de55d6 to d46ead3 Compare July 31, 2017 14:16
@stack72
Copy link
Contributor Author

stack72 commented Jul 31, 2017

@Ninir this is now taken care of :)

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDBInstance_basic -timeout 120m
=== RUN   TestAccAWSDBInstance_basic
--- PASS: TestAccAWSDBInstance_basic (616.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	616.271s

P.

Ninir
Ninir approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@Ninir Ninir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stack72

LGTM, thanks! :)

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBInstance_basic'      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSDBInstance_basic -timeout 120m
=== RUN   TestAccAWSDBInstance_basic
--- PASS: TestAccAWSDBInstance_basic (609.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	609.494s

@Ninir Ninir merged commit d12efee into hashicorp:master Jul 31, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ninir Ninir Ninir approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Add rds ca certificate identifier attribute
3 participants
@stack72 @Ninir @radeksimko