Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_fsx_windows_file_system: Prevent panic when update includes self_managed_active_directory settings #12630

Merged
merged 1 commit into from
Apr 28, 2020

Commits on Apr 2, 2020

  1. resource/aws_fsx_windows_file_system: Prevent panic when update inclu…

    …des `self_managed_active_directory` settings
    
    Reference: #11500
    
    Previously:
    
    ```
    === CONT  TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username
    panic: interface conversion: interface {} is *schema.Set, not []interface {}
    
    goroutine 4434 [running]:
    github.com/terraform-providers/terraform-provider-aws/aws.expandFsxSelfManagedActiveDirectoryConfigurationUpdate(0xc000488de0, 0x1, 0x1, 0x5b2f000)
    	/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_fsx_windows_file_system.go:413 +0x2d7
    github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsFsxWindowsFileSystemUpdate(0xc00004ed20, 0x62e3060, 0xc0003c3900, 0x0, 0x0)
    	/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_fsx_windows_file_system.go:269 +0x637
    github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).Apply(0xc00099b580, 0xc001cf2cd0, 0xc000ddebe0, 0x62e3060, 0xc0003c3900, 0x6168e01, 0xc001e73760, 0xc001914db0)
    	/Users/bflad/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.8.0/helper/schema/resource.go:311 +0x263
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (3063.70s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_basic (2915.15s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (4140.35s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (3034.18s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_disappears (3045.25s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (4148.71s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (4179.82s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (2905.75s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username (3731.46s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (4120.68s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_Tags (2968.90s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (4056.94s)
    --- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (3012.74s)
    ```
    bflad committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    79ed397 View commit details
    Browse the repository at this point in the history