Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/acm: Update acceptance tests to use ARN testing check functions #12717

Merged
merged 1 commit into from
Apr 9, 2020
Merged

service/acm: Update acceptance tests to use ARN testing check functions #12717

merged 1 commit into from
Apr 9, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Apr 7, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11888

Release note for CHANGELOG:

NONE

Previously:

aws/data_source_aws_acm_certificate_test.go:44:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:50:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:56:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:62:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:68:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:74:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:122:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:128:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/data_source_aws_acm_certificate_test.go:134:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:67:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:98:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:131:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:165:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:230:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:270:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:311:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:395:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:429:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_test.go:467:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_validation_test.go:26:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_validation_test.go:68:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_validation_test.go:103:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_validation_test.go:122:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_validation_test.go:142:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_validation_test.go:161:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_acm_certificate_validation_test.go:180:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)

Output from acceptance testing (test failures are present on master branch)

--- FAIL: TestAccAWSAcmCertificateDataSource_multipleIssued (6.47s)
--- FAIL: TestAccAWSAcmCertificateDataSource_singleIssued (6.47s)
--- PASS: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (17.50s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (27.91s)

--- FAIL: TestAccAWSAcmCertificate_privateCert (7.81s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (20.17s)
--- FAIL: TestAccAWSAcmCertificate_san_multiple (22.65s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (24.20s)
--- PASS: TestAccAWSAcmCertificate_root (24.43s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (24.43s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (24.83s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (26.01s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (26.99s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (28.13s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (28.96s)
--- PASS: TestAccAWSAcmCertificate_san_single (31.28s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (33.30s)
--- PASS: TestAccAWSAcmCertificate_wildcard (41.12s)
--- PASS: TestAccAWSAcmCertificate_tags (61.60s)

@gdavison gdavison requested a review from a team April 7, 2020 20:34
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 7, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 9, 2020
bflad
bflad approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing (test failures unrelated):

--- FAIL: TestAccAWSAcmCertificateDataSource_singleIssued (5.30s)
--- FAIL: TestAccAWSAcmCertificateDataSource_multipleIssued (5.32s)
--- FAIL: TestAccAWSAcmCertificate_privateCert (5.71s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (12.56s)
--- PASS: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (12.88s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (9.00s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (17.10s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (17.28s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (17.91s)
--- PASS: TestAccAWSAcmCertificate_root (18.09s)
--- PASS: TestAccAWSAcmCertificate_wildcard (18.11s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (18.84s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (20.16s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (20.35s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (21.28s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (21.14s)
--- PASS: TestAccAWSAcmCertificate_san_single (21.77s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (21.85s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (17.26s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (23.33s)
--- PASS: TestAccAWSAcmCertificate_tags (37.08s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (62.41s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (62.14s)
--- FAIL: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (63.96s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (100.85s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (91.48s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (107.25s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (143.19s)

@gdavison gdavison merged commit 7f4f64e into master Apr 9, 2020
@gdavison gdavison deleted the t-clean-up-acm-arn-tests branch April 9, 2020 22:29
@ghost
Copy link

ghost commented May 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/acm Issues and PRs that pertain to the acm service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @bflad