New resource - aws_ec2_client_vpn_route

[angelabad]

Create new resource for EC2 Client VPN routes (https://docs.aws.amazon.com/vpn/latest/clientvpn-admin/cvpn-working-routes.html)

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10437
Closes #7831

Release note for CHANGELOG:

New Resource: aws_ec2_client_vpn_route

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsEc2ClientVpnRoute'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ClientVpnRoute -timeout 120m
=== RUN   TestAccAwsEc2ClientVpnRoute_basic
=== PAUSE TestAccAwsEc2ClientVpnRoute_basic
=== RUN   TestAccAwsEc2ClientVpnRoute_disappears
=== PAUSE TestAccAwsEc2ClientVpnRoute_disappears
=== CONT  TestAccAwsEc2ClientVpnRoute_basic
=== CONT  TestAccAwsEc2ClientVpnRoute_disappears
--- PASS: TestAccAwsEc2ClientVpnRoute_basic (623.28s)
--- PASS: TestAccAwsEc2ClientVpnRoute_disappears (633.34s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       633.617s

[woz5999]

@bflad can you provide some guidance on how to get this reviewed and merged?

[gdavison]

Hi @angelabad. Thanks for this PR, it's a great start. I've started reviewing #10508, which duplicates this PR and was created earlier. Since there's another PR, I'll close this one. Thanks again!

[gdavison]

I'm going to reopen this PR, since it implements the routes as standalone resources instead of inline in aws_ec2_client_vpn_endpoint, which is the direction we'd prefer

[gdavison]

Sorry, I was thinking of the wrong PR 😬

[angelabad]

Hi @gdavison, if you need to me make changes in this pull request please tell me. Im active.

Cheers

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!