Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enable tfproviderlint S024 check: ForceNew is extraneous in data source schema attributes #12778

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Fix and enable tfproviderlint S024 check: ForceNew is extraneous in data source schema attributes #12778

merged 3 commits into from
Apr 13, 2020

Conversation

jbarnes7952
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #11868

Release note for CHANGELOG:

None

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmiDataSource -timeout 120m
=== RUN   TestAccAWSAmiDataSource_natInstance
=== PAUSE TestAccAWSAmiDataSource_natInstance
=== RUN   TestAccAWSAmiDataSource_windowsInstance
=== PAUSE TestAccAWSAmiDataSource_windowsInstance
=== RUN   TestAccAWSAmiDataSource_instanceStore
=== PAUSE TestAccAWSAmiDataSource_instanceStore
=== RUN   TestAccAWSAmiDataSource_localNameFilter
=== PAUSE TestAccAWSAmiDataSource_localNameFilter
=== CONT  TestAccAWSAmiDataSource_natInstance
=== CONT  TestAccAWSAmiDataSource_localNameFilter
=== CONT  TestAccAWSAmiDataSource_windowsInstance
=== CONT  TestAccAWSAmiDataSource_instanceStore
--- PASS: TestAccAWSAmiDataSource_instanceStore (21.57s)
--- PASS: TestAccAWSAmiDataSource_natInstance (23.52s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (24.36s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (26.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.028s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAutoScalingGroupDataSource -timeout 120m
=== RUN   TestAccAwsAutoScalingGroupDataSource_basic
=== PAUSE TestAccAwsAutoScalingGroupDataSource_basic
=== CONT  TestAccAwsAutoScalingGroupDataSource_basic
--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (56.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.517s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeCommitRepositoryDataSource -timeout 120m
=== RUN   TestAccAWSCodeCommitRepositoryDataSource_basic
=== PAUSE TestAccAWSCodeCommitRepositoryDataSource_basic
=== CONT  TestAccAWSCodeCommitRepositoryDataSource_basic
--- PASS: TestAccAWSCodeCommitRepositoryDataSource_basic (23.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.682s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataElasticacheCluster -timeout 120m
=== RUN   TestAccAWSDataElasticacheCluster_basic
=== PAUSE TestAccAWSDataElasticacheCluster_basic
=== CONT  TestAccAWSDataElasticacheCluster_basic
--- PASS: TestAccAWSDataElasticacheCluster_basic (429.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	429.102s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMServerCertificate -timeout 120m
=== RUN   TestAccAWSDataSourceIAMServerCertificate_basic
=== PAUSE TestAccAWSDataSourceIAMServerCertificate_basic
=== RUN   TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix
=== PAUSE TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix
=== RUN   TestAccAWSDataSourceIAMServerCertificate_path
=== PAUSE TestAccAWSDataSourceIAMServerCertificate_path
=== CONT  TestAccAWSDataSourceIAMServerCertificate_basic
=== CONT  TestAccAWSDataSourceIAMServerCertificate_path
=== CONT  TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix
--- PASS: TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix (3.85s)
--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (20.28s)
--- PASS: TestAccAWSDataSourceIAMServerCertificate_path (20.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.420s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDbInstanceDataSource -timeout 120m
=== RUN   TestAccAWSDbInstanceDataSource_basic
=== PAUSE TestAccAWSDbInstanceDataSource_basic
=== RUN   TestAccAWSDbInstanceDataSource_ec2Classic
=== PAUSE TestAccAWSDbInstanceDataSource_ec2Classic
=== CONT  TestAccAWSDbInstanceDataSource_basic
=== CONT  TestAccAWSDbInstanceDataSource_ec2Classic
    TestAccAWSDbInstanceDataSource_ec2Classic: provider_test.go:395: This test can only run in EC2 Classic, platforms available in us-east-1: ["VPC"]
--- SKIP: TestAccAWSDbInstanceDataSource_ec2Classic (1.66s)
--- PASS: TestAccAWSDbInstanceDataSource_basic (557.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	557.367s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDbSnapshotDataSource -timeout 120m
=== RUN   TestAccAWSDbSnapshotDataSource_basic
=== PAUSE TestAccAWSDbSnapshotDataSource_basic
=== CONT  TestAccAWSDbSnapshotDataSource_basic
--- PASS: TestAccAWSDbSnapshotDataSource_basic (599.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	599.019s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEbsSnapshotDataSource -timeout 120m
=== RUN   TestAccAWSEbsSnapshotDataSource_basic
=== PAUSE TestAccAWSEbsSnapshotDataSource_basic
=== RUN   TestAccAWSEbsSnapshotDataSource_Filter
=== PAUSE TestAccAWSEbsSnapshotDataSource_Filter
=== RUN   TestAccAWSEbsSnapshotDataSource_MostRecent
=== PAUSE TestAccAWSEbsSnapshotDataSource_MostRecent
=== CONT  TestAccAWSEbsSnapshotDataSource_basic
=== CONT  TestAccAWSEbsSnapshotDataSource_MostRecent
=== CONT  TestAccAWSEbsSnapshotDataSource_Filter
--- PASS: TestAccAWSEbsSnapshotDataSource_basic (38.46s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (52.51s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (89.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	89.874s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEbsVolumeDataSource -timeout 120m
=== RUN   TestAccAWSEbsVolumeDataSource_basic
=== PAUSE TestAccAWSEbsVolumeDataSource_basic
=== RUN   TestAccAWSEbsVolumeDataSource_multipleFilters
=== PAUSE TestAccAWSEbsVolumeDataSource_multipleFilters
=== CONT  TestAccAWSEbsVolumeDataSource_basic
=== CONT  TestAccAWSEbsVolumeDataSource_multipleFilters
--- PASS: TestAccAWSEbsVolumeDataSource_basic (35.54s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (35.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.800s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcrDataSource -timeout 120m
=== RUN   TestAccAWSEcrDataSource_ecrImage
=== PAUSE TestAccAWSEcrDataSource_ecrImage
=== RUN   TestAccAWSEcrDataSource_ecrRepository
=== PAUSE TestAccAWSEcrDataSource_ecrRepository
=== CONT  TestAccAWSEcrDataSource_ecrImage
=== CONT  TestAccAWSEcrDataSource_ecrRepository
--- PASS: TestAccAWSEcrDataSource_ecrImage (22.14s)
--- PASS: TestAccAWSEcrDataSource_ecrRepository (24.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.558s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsDataSource -timeout 120m
=== RUN   TestAccAWSEcsDataSource_ecsCluster
=== PAUSE TestAccAWSEcsDataSource_ecsCluster
=== RUN   TestAccAWSEcsDataSource_ecsClusterContainerInsights
=== PAUSE TestAccAWSEcsDataSource_ecsClusterContainerInsights
=== RUN   TestAccAWSEcsDataSource_ecsContainerDefinition
=== PAUSE TestAccAWSEcsDataSource_ecsContainerDefinition
=== RUN   TestAccAWSEcsDataSource_ecsTaskDefinition
=== PAUSE TestAccAWSEcsDataSource_ecsTaskDefinition
=== CONT  TestAccAWSEcsDataSource_ecsCluster
=== CONT  TestAccAWSEcsDataSource_ecsTaskDefinition
=== CONT  TestAccAWSEcsDataSource_ecsContainerDefinition
=== CONT  TestAccAWSEcsDataSource_ecsClusterContainerInsights
--- PASS: TestAccAWSEcsDataSource_ecsTaskDefinition (22.69s)
--- PASS: TestAccAWSEcsDataSource_ecsCluster (32.86s)
--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (33.19s)
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (93.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.227s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsServiceDataSource -timeout 120m
=== RUN   TestAccAWSEcsServiceDataSource_basic
=== PAUSE TestAccAWSEcsServiceDataSource_basic
=== CONT  TestAccAWSEcsServiceDataSource_basic
--- PASS: TestAccAWSEcsServiceDataSource_basic (94.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	94.117s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksClusterDataSource -timeout 120m
=== RUN   TestAccAWSEksClusterDataSource_basic
=== PAUSE TestAccAWSEksClusterDataSource_basic
=== CONT  TestAccAWSEksClusterDataSource_basic
--- PASS: TestAccAWSEksClusterDataSource_basic (1296.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1296.447s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsElasticBeanstalkApplicationDataSource -timeout 120m
=== RUN   TestAccAwsElasticBeanstalkApplicationDataSource_basic
=== PAUSE TestAccAwsElasticBeanstalkApplicationDataSource_basic
=== CONT  TestAccAwsElasticBeanstalkApplicationDataSource_basic
--- PASS: TestAccAwsElasticBeanstalkApplicationDataSource_basic (27.05s)
PASS

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticBeanstalkSolutionStackDataSource -timeout 120m
=== RUN   TestAccAWSElasticBeanstalkSolutionStackDataSource
=== PAUSE TestAccAWSElasticBeanstalkSolutionStackDataSource
=== CONT  TestAccAWSElasticBeanstalkSolutionStackDataSource
--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource (21.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.330s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsSecretDataSource -timeout 120m
=== RUN   TestAccAWSKmsSecretDataSource_removed
=== PAUSE TestAccAWSKmsSecretDataSource_removed
=== CONT  TestAccAWSKmsSecretDataSource_removed
--- PASS: TestAccAWSKmsSecretDataSource_removed (3.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.748s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKmsSecretsDataSource -timeout 120m
=== RUN   TestAccAWSKmsSecretsDataSource_basic
--- PASS: TestAccAWSKmsSecretsDataSource_basic (90.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	90.365s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAmiIds -timeout 120m
=== RUN   TestAccDataSourceAwsAmiIds_basic
=== PAUSE TestAccDataSourceAwsAmiIds_basic
=== RUN   TestAccDataSourceAwsAmiIds_sorted
=== PAUSE TestAccDataSourceAwsAmiIds_sorted
=== CONT  TestAccDataSourceAwsAmiIds_basic
=== CONT  TestAccDataSourceAwsAmiIds_sorted
--- PASS: TestAccDataSourceAwsAmiIds_basic (22.76s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (36.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.336s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsBatchComputeEnvironment -timeout 120m
=== RUN   TestAccDataSourceAwsBatchComputeEnvironment
=== PAUSE TestAccDataSourceAwsBatchComputeEnvironment
=== CONT  TestAccDataSourceAwsBatchComputeEnvironment
--- PASS: TestAccDataSourceAwsBatchComputeEnvironment (65.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.013s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsBatchJobQueue -timeout 120m
=== RUN   TestAccDataSourceAwsBatchJobQueue
=== PAUSE TestAccDataSourceAwsBatchJobQueue
=== CONT  TestAccDataSourceAwsBatchJobQueue
--- PASS: TestAccDataSourceAwsBatchJobQueue (150.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	150.564s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEbsSnapshotIds -timeout 120m
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_basic
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_basic
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_sorted
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_sorted
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_empty
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_empty
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_basic
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_empty
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_sorted
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_empty (20.90s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (36.88s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_sorted (81.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	81.437s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEfsFileSystem -timeout 120m
=== RUN   TestAccDataSourceAwsEfsFileSystem_id
=== PAUSE TestAccDataSourceAwsEfsFileSystem_id
=== RUN   TestAccDataSourceAwsEfsFileSystem_name
=== PAUSE TestAccDataSourceAwsEfsFileSystem_name
=== CONT  TestAccDataSourceAwsEfsFileSystem_id
=== CONT  TestAccDataSourceAwsEfsFileSystem_name
--- PASS: TestAccDataSourceAwsEfsFileSystem_id (32.20s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (32.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.221s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEfsMountTargetByMountTargetId -timeout 120m
=== RUN   TestAccDataSourceAwsEfsMountTargetByMountTargetId
=== PAUSE TestAccDataSourceAwsEfsMountTargetByMountTargetId
=== CONT  TestAccDataSourceAwsEfsMountTargetByMountTargetId
--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId (151.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	151.227s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsLambdaInvocation -timeout 120m
=== RUN   TestAccDataSourceAwsLambdaInvocation_basic
=== PAUSE TestAccDataSourceAwsLambdaInvocation_basic
=== RUN   TestAccDataSourceAwsLambdaInvocation_qualifier
=== PAUSE TestAccDataSourceAwsLambdaInvocation_qualifier
=== RUN   TestAccDataSourceAwsLambdaInvocation_complex
=== PAUSE TestAccDataSourceAwsLambdaInvocation_complex
=== CONT  TestAccDataSourceAwsLambdaInvocation_basic
=== CONT  TestAccDataSourceAwsLambdaInvocation_complex
=== CONT  TestAccDataSourceAwsLambdaInvocation_qualifier
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (47.90s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (54.40s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (61.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.326s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSecretsManagerSecretVersion -timeout 120m
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_Basic
=== PAUSE TestAccDataSourceAwsSecretsManagerSecretVersion_Basic
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID
=== PAUSE TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage
=== PAUSE TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage
=== CONT  TestAccDataSourceAwsSecretsManagerSecretVersion_Basic
=== CONT  TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage
=== CONT  TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage (25.26s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID (25.31s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_Basic (27.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	27.580s

...

@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/batch Issues and PRs that pertain to the batch service. service/codecommit Issues and PRs that pertain to the codecommit service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticache Issues and PRs that pertain to the elasticache service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. labels Apr 11, 2020
@melamity melamity mentioned this pull request Apr 11, 2020
Closed
@jbarnes7952 jbarnes7952 marked this pull request as ready for review April 12, 2020 10:42
@jbarnes7952 jbarnes7952 requested a review from a team April 12, 2020 10:42
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 12, 2020
@bflad bflad self-assigned this Apr 12, 2020
@bflad bflad added this to the v2.58.0 milestone Apr 13, 2020
bflad
bflad approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @jbarnes7952 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAmiDataSource_instanceStore (11.13s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (15.32s)
--- PASS: TestAccAWSAmiDataSource_natInstance (13.99s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (13.39s)

--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (50.41s)

--- PASS: TestAccAWSCodeCommitRepositoryDataSource_basic (12.00s)

--- PASS: TestAccAWSDataElasticacheCluster_basic (442.71s)

--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (12.84s)
--- PASS: TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix (2.16s)
--- PASS: TestAccAWSDataSourceIAMServerCertificate_path (12.66s)

--- PASS: TestAccAWSDbInstanceDataSource_basic (549.25s)

--- PASS: TestAccAWSDbSnapshotDataSource_basic (608.29s)

--- PASS: TestAccAWSEbsSnapshotDataSource_basic (37.87s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (38.63s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (127.50s)

--- PASS: TestAccAWSEbsVolumeDataSource_basic (22.31s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (21.03s)

--- PASS: TestAccAWSEcrDataSource_ecrImage (8.32s)
--- PASS: TestAccAWSEcrDataSource_ecrRepository (8.66s)
--- PASS: TestAccAWSEcsDataSource_ecsCluster (18.30s)
--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (19.29s)
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (84.17s)
--- PASS: TestAccAWSEcsDataSource_ecsTaskDefinition (10.44s)

--- PASS: TestAccAWSEcsServiceDataSource_basic (64.21s)

--- PASS: TestAccAWSEksClusterDataSource_basic (1200.12s)

--- PASS: TestAccAwsElasticBeanstalkApplicationDataSource_basic (13.95s)
--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource (8.46s)

--- PASS: TestAccAWSInstanceDataSource_AzUserData (109.65s)
--- PASS: TestAccAWSInstanceDataSource_basic (231.26s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (192.31s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (75.29s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (99.70s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (349.73s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (137.55s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (130.40s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (91.36s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (181.87s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (184.36s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (214.12s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (58.78s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (86.09s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (210.39s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (69.48s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (144.62s)
--- PASS: TestAccAWSInstanceDataSource_tags (200.62s)
--- PASS: TestAccAWSInstanceDataSource_VPC (104.76s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (196.40s)

--- PASS: TestAccAWSKmsSecretDataSource_removed (1.77s)

--- PASS: TestAccAWSKmsSecretsDataSource_basic (51.53s)

--- PASS: TestAccDataSourceAwsAmiIds_basic (11.97s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (22.14s)

--- PASS: TestAccDataSourceAwsBatchComputeEnvironment (51.50s)

--- PASS: TestAccDataSourceAwsBatchJobQueue (82.31s)

--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (38.72s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_empty (11.51s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_sorted (56.91s)

--- PASS: TestAccDataSourceAwsEfsFileSystem_id (16.13s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (16.09s)

--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId (120.55s)

--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (25.25s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (33.52s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (33.41s)

--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_Basic (9.52s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID (8.43s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage (18.48s)

@bflad bflad merged commit 8a06097 into hashicorp:master Apr 13, 2020
nl-brett-stime pushed a commit to nl-brett-stime/terraform-provider-aws that referenced this pull request Apr 15, 2020
@jbarnes7952 @b-stime
provider: Fix and enable tfproviderlint S024 check: ForceNew is extra…
934b56e 
…neous in data source schema attributes (hashicorp#12778)

Output from acceptance testing:

```
--- PASS: TestAccAWSAmiDataSource_instanceStore (11.13s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (15.32s)
--- PASS: TestAccAWSAmiDataSource_natInstance (13.99s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (13.39s)

--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (50.41s)

--- PASS: TestAccAWSCodeCommitRepositoryDataSource_basic (12.00s)

--- PASS: TestAccAWSDataElasticacheCluster_basic (442.71s)

--- PASS: TestAccAWSDataSourceIAMServerCertificate_basic (12.84s)
--- PASS: TestAccAWSDataSourceIAMServerCertificate_matchNamePrefix (2.16s)
--- PASS: TestAccAWSDataSourceIAMServerCertificate_path (12.66s)

--- PASS: TestAccAWSDbInstanceDataSource_basic (549.25s)

--- PASS: TestAccAWSDbSnapshotDataSource_basic (608.29s)

--- PASS: TestAccAWSEbsSnapshotDataSource_basic (37.87s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (38.63s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (127.50s)

--- PASS: TestAccAWSEbsVolumeDataSource_basic (22.31s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (21.03s)

--- PASS: TestAccAWSEcrDataSource_ecrImage (8.32s)
--- PASS: TestAccAWSEcrDataSource_ecrRepository (8.66s)
--- PASS: TestAccAWSEcsDataSource_ecsCluster (18.30s)
--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (19.29s)
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (84.17s)
--- PASS: TestAccAWSEcsDataSource_ecsTaskDefinition (10.44s)

--- PASS: TestAccAWSEcsServiceDataSource_basic (64.21s)

--- PASS: TestAccAWSEksClusterDataSource_basic (1200.12s)

--- PASS: TestAccAwsElasticBeanstalkApplicationDataSource_basic (13.95s)
--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource (8.46s)

--- PASS: TestAccAWSInstanceDataSource_AzUserData (109.65s)
--- PASS: TestAccAWSInstanceDataSource_basic (231.26s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (192.31s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (75.29s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (99.70s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (349.73s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (137.55s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (130.40s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (91.36s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (181.87s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (184.36s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (214.12s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (58.78s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (86.09s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (210.39s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (69.48s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (144.62s)
--- PASS: TestAccAWSInstanceDataSource_tags (200.62s)
--- PASS: TestAccAWSInstanceDataSource_VPC (104.76s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (196.40s)

--- PASS: TestAccAWSKmsSecretDataSource_removed (1.77s)

--- PASS: TestAccAWSKmsSecretsDataSource_basic (51.53s)

--- PASS: TestAccDataSourceAwsAmiIds_basic (11.97s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (22.14s)

--- PASS: TestAccDataSourceAwsBatchComputeEnvironment (51.50s)

--- PASS: TestAccDataSourceAwsBatchJobQueue (82.31s)

--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (38.72s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_empty (11.51s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_sorted (56.91s)

--- PASS: TestAccDataSourceAwsEfsFileSystem_id (16.13s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (16.09s)

--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId (120.55s)

--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (25.25s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (33.52s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (33.41s)

--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_Basic (9.52s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionID (8.43s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_VersionStage (18.48s)
```
@ghost
Copy link

ghost commented Apr 17, 2020

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/autoscaling Issues and PRs that pertain to the autoscaling service. service/batch Issues and PRs that pertain to the batch service. service/codecommit Issues and PRs that pertain to the codecommit service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.58.0
Development

Successfully merging this pull request may close these issues.

Fix and enable tfproviderlint S024 check: ForceNew is extraneous in data source schema attributes
2 participants
@jbarnes7952 @bflad