Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Vendor github.com/aws/aws-sdk-go/service/route53domains #12797

Merged
merged 2 commits into from
Apr 14, 2020
Merged

deps: Vendor github.com/aws/aws-sdk-go/service/route53domains #12797

merged 2 commits into from
Apr 14, 2020

Conversation

gazoakley
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #88

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ go test ./aws
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.003s

@gazoakley gazoakley requested a review from a team April 13, 2020 12:24
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. labels Apr 13, 2020
@gazoakley
Copy link
Contributor Author

This will allow me to update #12711

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 13, 2020
bflad
bflad reviewed Apr 13, 2020
View reviewed changes
.hashibot.hcl Outdated
@@ -425,7 +425,7 @@ behavior "regexp_issue_labeler_v2" "service_labels" {
"aws_route53_([^d]|d[^o]|do[^m]|dom[^a]|doma[^i]|domai[^n]|domain[^s]|domains[^_]|[^r]|r[^e]|re[^s]|res[^o]|reso[^l]|resol[^v]|resolv[^e]|resolve[^r]|resolver[^_])",
],
"service/route53domains" = [
"aws_route53_domains_",
"aws_route53_domain",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our preference for naming these resources will be aws_route53domains_THING, e.g. aws_route53domains_domain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with Route53 Resolver - wouldn't it then be better to go with aws_route53_domains_domain? (although that feels a bit repetitive too 😄)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, we'd really like to get in the habit of aws_SERVICE_THING to more align with CloudFormation resources as well as prevent any oddities of V2 APIs. See also: #8842 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to aws_route53domains_ to match service name

bflad
bflad approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the hashibot configuration is updated. 👍

--- PASS: TestAccAWSProvider_Endpoints (7.92s)
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (8.14s)

@bflad bflad added this to the v2.58.0 milestone Apr 14, 2020
@bflad bflad merged commit 24fa83a into hashicorp:master Apr 14, 2020
@ghost
Copy link

ghost commented Apr 17, 2020

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@gazoakley gazoakley mentioned this pull request Apr 25, 2020
Merged
@ghost
Copy link

ghost commented May 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.58.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gazoakley @bflad