Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enable tfproviderlint R005 check: Combine multiple d.HasChange() calls with d.HasChanges() call #12811

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Fix and enable tfproviderlint R005 check: Combine multiple d.HasChange() calls with d.HasChanges() call #12811

merged 3 commits into from
Jun 16, 2020

Conversation

jbarnes7952
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #11863

autoscaling_tags.go:59:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_acm_certificate.go:295:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_cloudtrail.go:318:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_datasync_task.go:279:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_db_instance.go:1465:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_db_instance.go:1598:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_db_instance.go:1604:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_db_subnet_group.go:169:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_dms_endpoint.go:423:6: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_dms_endpoint.go:461:6: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_docdb_subnet_group.go:154:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_dynamodb_table.go:476:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_dynamodb_table.go:492:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_ec2_transit_gateway_vpc_attachment.go:213:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_ec2_transit_gateway_vpc_attachment.go:243:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_ec2_transit_gateway_vpc_attachment_accepter.go:192:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_ecs_cluster.go:259:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_ecs_service.go:910:6: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_efs_file_system.go:204:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_eip.go:294:14: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_eip.go:311:13: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_eks_cluster.go:408:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_eks_node_group.go:340:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_eks_node_group.go:372:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_elasticache_subnet_group.go:130:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_elasticsearch_domain.go:724:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_elb.go:569:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_elb.go:609:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_emr_instance_group.go:289:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_gamelift_fleet.go:355:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_globalaccelerator_accelerator.go:265:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_glue_catalog_database.go:111:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_glue_crawler.go:461:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_glue_job.go:324:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_glue_trigger.go:306:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_iam_group.go:101:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_iam_user.go:141:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_lambda_function.go:195:9: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_media_convert_queue.go:175:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_mq_broker.go:405:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_msk_cluster.go:539:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_neptune_subnet_group.go:165:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_ram_resource_share.go:134:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_rds_cluster_instance.go:497:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_redshift_cluster.go:661:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_redshift_subnet_group.go:136:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_route53_health_check.go:189:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_route53_resolver_rule.go:191:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_s3_bucket_object.go:456:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_secretsmanager_secret.go:261:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_secretsmanager_secret.go:307:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_storagegateway_gateway.go:400:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_transfer_server.go:230:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_vpc_peering_connection.go:239:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_waf_web_acl.go:283:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_wafregional_rate_based_rule.go:174:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_wafregional_web_acl.go:300:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
resource_aws_worklink_fleet.go:237:5: R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/acm Issues and PRs that pertain to the acm service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/databasemigrationservice service/datasync Issues and PRs that pertain to the datasync service. service/docdb Issues and PRs that pertain to the docdb service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/gamelift Issues and PRs that pertain to the gamelift service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/rds Issues and PRs that pertain to the rds service. labels Apr 14, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2020
@gdavison gdavison added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Apr 24, 2020
@bflad
Copy link
Contributor

bflad commented May 21, 2020

Hey @jbarnes7952 👋 Thank you for picking this up! Do you intend on working on this more? Just trying to gauge if the team should review it, running testing, finish it up, etc. Thanks. 😄

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 21, 2020
@gdavison gdavison self-requested a review June 12, 2020 23:03
gdavison
gdavison reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few line length formatting changes to make

aws/resource_aws_dms_endpoint.go Outdated
d.HasChange("mongodb_settings.0.extract_doc_id") ||
d.HasChange("mongodb_settings.0.docs_to_investigate") ||
d.HasChange("mongodb_settings.0.auth_source") {
if d.HasChanges("username", "password", "server_name", "port", "database_name", "mongodb_settings.0.auth_type", "mongodb_settings.0.auth_mechanism", "mongodb_settings.0.nesting_level", "mongodb_settings.0.extract_doc_id", "mongodb_settings.0.docs_to_investigate", "mongodb_settings.0.auth_source") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability, this might be better broken over several lines

aws/resource_aws_dms_endpoint.go Outdated
d.HasChange("s3_settings.0.bucket_folder") ||
d.HasChange("s3_settings.0.bucket_name") ||
d.HasChange("s3_settings.0.compression_type") {
if d.HasChanges("s3_settings.0.service_access_role_arn", "s3_settings.0.external_table_definition", "s3_settings.0.csv_row_delimiter", "s3_settings.0.csv_delimiter", "s3_settings.0.bucket_folder", "s3_settings.0.bucket_name", "s3_settings.0.compression_type") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be split over several lines as well

aws/resource_aws_glue_crawler.go Outdated
d.HasChange("schema_change_policy") ||
d.HasChange("security_configuration") ||
d.HasChange("table_prefix") {
if d.HasChanges("catalog_target", "classifiers", "configuration", "description", "dynamodb_target", "jdbc_target", "role", "s3_target", "schedule", "schema_change_policy", "security_configuration", "table_prefix") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be broken over several lines

@gdavison gdavison marked this pull request as ready for review June 15, 2020 23:36
@gdavison gdavison requested a review from a team June 15, 2020 23:36
@gdavison gdavison self-assigned this Jun 15, 2020
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jun 15, 2020
gdavison
gdavison approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSCloudTrailServiceAccount_basic (12.79s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (12.81s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (14.13s)
--- PASS: TestAccAWSAcmCertificate_root (18.66s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (20.28s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (20.54s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (20.83s)
--- PASS: TestAccAWSAcmCertificate_wildcard (21.19s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (22.86s)
--- PASS: TestAccAWSAcmCertificate_privateCert (22.84s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (23.27s)
--- SKIP: TestAccAWSDataSyncTask_Tags (0.00s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (24.12s)
--- PASS: TestAccAWSAcmCertificate_san_single (24.70s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (25.24s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (25.65s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (25.82s)
--- PASS: TestAccAWSAcmCertificate_tags (39.16s)
--- FAIL: TestAccAWSDataSyncTask_disappears (202.65s)
--- FAIL: TestAccAWSDataSyncTask_basic (211.18s)
--- FAIL: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (190.40s)
--- FAIL: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (202.96s)
--- FAIL: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (210.59s)
--- FAIL: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (215.63s)
--- FAIL: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (230.06s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (261.74s)
--- PASS: TestAccAWSCloudTrail (289.27s)
--- PASS: TestAccAWSCloudTrail/Trail (289.27s)
--- PASS: TestAccAWSCloudTrail/Trail/isMultiRegion (40.31s)
--- SKIP: TestAccAWSCloudTrail/Trail/isOrganization (1.00s)
--- PASS: TestAccAWSCloudTrail/Trail/logValidation (33.59s)
--- PASS: TestAccAWSCloudTrail/Trail/eventSelector (37.57s)
--- PASS: TestAccAWSCloudTrail/Trail/basic (22.79s)
--- PASS: TestAccAWSCloudTrail/Trail/cloudwatch (50.12s)
--- PASS: TestAccAWSCloudTrail/Trail/enableLogging (32.43s)
--- PASS: TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents (15.12s)
--- PASS: TestAccAWSCloudTrail/Trail/kmsKey (14.81s)
--- PASS: TestAccAWSCloudTrail/Trail/tags (41.53s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (278.53s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (296.24s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (312.18s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (469.33s)
--- PASS: TestAccAWSDBInstance_basic (485.68s)
--- PASS: TestAccAWSDBInstance_kmsKey (485.17s)
--- PASS: TestAccAWSDBInstance_generatedName (505.14s)
--- PASS: TestAccAWSDBInstance_iamAuth (534.84s)
--- PASS: TestAccAWSDBInstance_namePrefix (565.52s)
--- PASS: TestAccAWSDBInstance_optionGroup (565.58s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (478.03s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (472.25s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (474.37s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (524.30s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (530.10s)
--- PASS: TestAccAWSDBInstance_Password (557.71s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (641.63s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (726.47s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (746.96s)
--- PASS: TestAccAWSDBInstance_subnetGroup (1095.46s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1474.12s)
--- FAIL: TestAccAWSDBInstance_S3Import (682.16s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1564.74s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1465.86s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1494.54s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1494.42s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1363.27s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1403.93s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1818.70s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1443.68s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1807.34s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1598.84s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1534.49s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1483.94s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1557.08s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1606.54s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (2304.10s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2170.95s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (2379.83s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1221.99s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1171.05s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (2618.52s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1212.70s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1474.32s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1190.73s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (1153.15s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1565.51s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1422.71s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1194.02s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (1216.14s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1504.14s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1160.87s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1318.58s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1421.94s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1291.39s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (1949.35s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (614.59s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (778.97s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1305.84s)
--- PASS: TestAccAWSDBInstance_portUpdate (639.64s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (775.06s)
--- PASS: TestAccAWSDBInstance_separate_iops_update (711.03s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (940.94s)
--- PASS: TestAccAWSDBInstance_MinorVersion (472.98s)
--- PASS: TestAccAWSDBInstance_ec2Classic (430.25s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1152.79s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1452.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1272.19s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1312.27s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1253.67s)
--- PASS: TestAccAWSDBSubnetGroup_basic (12.78s)
--- PASS: TestAccAWSDBSubnetGroup_namePrefix (12.55s)
--- PASS: TestAccAWSDBSubnetGroup_generatedName (22.83s)
--- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (12.50s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (518.25s)
--- PASS: TestAccAWSDBSubnetGroup_updateDescription (20.48s)
--- PASS: TestAccAwsDmsEndpoint_Basic (13.91s)
--- PASS: TestAccAwsDmsEndpoint_S3 (26.59s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (34.83s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch (28.11s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration (28.06s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage (20.17s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Broker (13.43s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Topic (13.92s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb (15.21s)
--- PASS: TestAccAwsDmsEndpoint_DocDB (13.48s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (13.80s)
--- PASS: TestAccAwsDmsEndpoint_Kinesis (60.52s)
--- PASS: TestAccAWSDocDBSubnetGroup_basic (12.14s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (585.01s)
--- PASS: TestAccAWSDocDBSubnetGroup_disappears (11.12s)
--- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (11.80s)
--- PASS: TestDiffDynamoDbGSI (0.00s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (509.57s)
--- PASS: TestAccAWSDocDBSubnetGroup_generatedName (12.16s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (534.56s)
--- PASS: TestAccAWSDocDBSubnetGroup_updateDescription (18.41s)
--- PASS: TestAccAWSDynamoDbTable_disappears (13.05s)
--- PASS: TestAccAWSDynamoDbTable_basic (16.43s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (29.47s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1887.60s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (39.18s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (54.58s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (2.91s)
--- PASS: TestAccAWSDynamoDbTable_tags (24.10s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (36.37s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (45.79s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (770.14s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (34.29s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (716.36s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (17.96s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (4.26s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (21.70s)
--- PASS: TestAccAWSDynamoDbTable_extended (218.80s)
--- PASS: TestAccAWSDynamoDbTable_encryption (98.01s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (138.87s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (482.66s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (775.88s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1525.34s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (833.17s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsRetentionPeriod (883.30s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_Tags (285.14s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_basic (271.10s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_basic (296.57s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (413.04s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (449.44s)
--- PASS: TestAccAWSRDSDBInstance_PerformanceInsightsKmsKeyId (960.91s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentAccepter_TransitGatewayDefaultRouteTableAssociationAndPropagation (399.25s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Single (412.10s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_disappears (289.61s)
--- PASS: TestAccAWSEcsCluster_disappears (16.36s)
--- PASS: TestAccAWSEcsCluster_basic (18.18s)
--- PASS: TestAccAWSEcsCluster_Tags (28.74s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (35.07s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (72.94s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (63.00s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (46.93s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SharedTransitGateway (220.88s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (219.17s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_DnsSupport (333.96s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Ipv6Support (255.39s)
--- PASS: TestAccAWSEcsCluster_containerInsights (47.94s)
--- PASS: TestAccAWSEcsService_disappears (63.18s)
--- PASS: TestAccAWSEcsService_basicImport (75.09s)
--- PASS: TestAccAWSEcsService_withARN (88.61s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (83.41s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (68.48s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTablePropagation (328.48s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (118.22s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_Tags (358.44s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (137.15s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (73.08s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (134.36s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_TransitGatewayDefaultRouteTableAssociation (396.21s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachment_SubnetIds (416.01s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (63.00s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (63.37s)
--- PASS: TestAccAWSEcsService_withIamRole (134.39s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (52.93s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (58.50s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (68.79s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (996.99s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (89.20s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (42.74s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1999.56s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (64.24s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (73.55s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (260.40s)
--- PASS: TestResourceAWSEFSFileSystem_hasEmptyFileSystems (0.00s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (130.66s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (120.47s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (15.64s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (83.30s)
--- PASS: TestAccAWSEFSFileSystem_basic (27.90s)
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (5.10s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (267.04s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (21.44s)
--- PASS: TestAccAWSEcsService_withLbChanges (237.29s)
--- PASS: TestAccAWSEcsService_ManagedTags (63.34s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (34.63s)
--- PASS: TestAccAWSEcsService_Tags (85.40s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (41.84s)
--- PASS: TestAccAWSEIP_basic (8.62s)
--- PASS: TestAccAWSEcsService_withAlb (266.43s)
--- PASS: TestAccAWSEFSFileSystem_disappears (42.32s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (66.33s)
--- PASS: TestAccAWSEFSFileSystem_tags (97.20s)
--- PASS: TestAccAWSEIP_networkInterface (26.05s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (60.66s)
--- PASS: TestAccAWSEIP_disappears (6.55s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (153.95s)
--- SKIP: TestAccAWSEIP_PublicIpv4Pool_custom (0.00s)
--- SKIP: TestAccAWSEIP_CustomerOwnedIpv4Pool (0.00s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (267.01s)
--- PASS: TestAccAWSEIP_twoEIPsOneNetworkInterface (26.06s)
--- PASS: TestAccAWSEIP_PublicIpv4Pool_default (9.72s)
--- PASS: TestAccAWSEIP_tags (15.35s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (154.51s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (101.40s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1544.26s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (1101.65s)
--- PASS: TestAccAWSEIP_instance (115.41s)
--- FAIL: TestAccAWSEIP_Ec2Classic (122.90s)
--- PASS: TestAccAWSEIP_Instance_Reassociate (106.86s)
--- PASS: TestAccAWSEcsService_PropagateTags (205.60s)
--- PASS: TestAccAWSEIPAssociate_notAssociated (123.78s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1646.96s)
--- PASS: TestAccAWSEIP_associated_user_private_ip (160.30s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (1596.15s)
--- PASS: TestAccAWSEksCluster_basic (657.91s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (2919.55s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (729.23s)
--- PASS: TestAccAWSEksCluster_Tags (836.45s)
--- PASS: TestAccAWSEksCluster_EncryptionConfig (871.95s)
--- PASS: TestAccAWSEksCluster_Logging (924.36s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3203.12s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3996.50s)
--- PASS: TestAccAWSElasticacheSubnetGroup_basic (13.25s)
--- PASS: TestAccAWSElasticacheSubnetGroup_update (19.83s)
--- PASS: TestAccAWSEksCluster_VpcConfig_PublicAccessCidrs (1012.95s)
--- PASS: TestAccAWSEksNodeGroup_AmiType (1010.12s)
--- PASS: TestAccAWSEksNodeGroup_basic (1040.69s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes (1040.11s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1042.17s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1161.71s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1193.56s)
--- PASS: TestAccAWSElasticSearchDomain_basic (629.61s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1660.41s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (570.27s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1120.81s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1086.52s)
--- PASS: TestAccAWSElasticSearchDomain_duplicate (702.67s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1244.62s)
--- PASS: TestAccAWSElasticSearchDomain_complex (710.93s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1116.85s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1046.38s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (1974.05s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1206.90s)
--- PASS: TestAccAWSEksCluster_Version (2174.82s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1162.58s)
--- PASS: TestAccAWSELB_basic (23.07s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (709.92s)
--- PASS: TestAccAWSELB_disappears (11.20s)
--- PASS: TestAccAWSELB_fullCharacterRange (13.32s)
--- PASS: TestAccAWSELB_AccessLogs_enabled (27.48s)
--- PASS: TestAccAWSELB_AccessLogs_disabled (26.60s)
--- PASS: TestAccAWSELB_namePrefix (12.97s)
--- PASS: TestAccAWSELB_generatedName (12.13s)
--- PASS: TestAccAWSELB_generatesNameForZeroValue (11.76s)
--- PASS: TestAccAWSELB_availabilityZones (18.70s)
--- PASS: TestAccAWSELB_tags (25.09s)
--- PASS: TestAccAWSELB_Listener_SSLCertificateID_IAMServerCertificate (28.71s)
--- PASS: TestAccAWSELB_swap_subnets (33.10s)
--- PASS: TestAccAWSElasticSearchDomain_policy (707.70s)
--- PASS: TestAccAWSELB_HealthCheck (12.40s)
--- PASS: TestAccAWSELB_listener (41.85s)
--- PASS: TestAccAWSELBUpdate_HealthCheck (19.95s)
--- PASS: TestAccAWSELB_Timeout (12.23s)
--- PASS: TestAccAWSELBUpdate_Timeout (19.78s)
--- PASS: TestAccAWSELB_ConnectionDraining (11.62s)
--- PASS: TestAccAWSELB_SecurityGroups (19.12s)
--- PASS: TestResourceAwsElbListenerHash (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotBeginWithHyphen (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCanBeAnEmptyString (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotBeLongerThan32Characters (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotHaveSpecialCharacters (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotEndWithHyphen (0.00s)
--- PASS: TestResourceAWSELB_validateAccessLogsInterval (0.00s)
--- PASS: TestResourceAWSELB_validateHealthCheckTarget (0.00s)
--- PASS: TestAccAWSELBUpdate_ConnectionDraining (26.04s)
--- PASS: TestAccAWSElasticSearchDomain_RequireHTTPS (1750.23s)
--- PASS: TestAccAWSELB_InstanceAttaching (296.24s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (981.32s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (958.64s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1083.34s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1424.18s)
--- PASS: TestDiffGameliftPortSettings (0.00s)
--- PASS: TestAccAWSEMRInstanceGroup_basic (825.54s)
--- PASS: TestAccAWSEMRInstanceGroup_EmrClusterDisappears (649.60s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (1913.73s)
--- PASS: TestAccAWSEMRInstanceGroup_ConfigurationsJson (834.78s)
--- PASS: TestAccAWSEMRInstanceGroup_AutoScalingPolicy (830.39s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (1917.28s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (67.52s)
--- PASS: TestAccAWSEMRInstanceGroup_InstanceCount (865.51s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (70.05s)
--- PASS: TestAccAWSGlueCatalogDatabase_recreates (9.18s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (19.31s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (95.76s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (68.35s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (38.14s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (37.62s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (37.82s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2126.07s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (45.24s)
--- PASS: TestAccAWSGlueCrawler_S3Target (37.01s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (37.45s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (36.74s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (38.17s)
--- PASS: TestAccAWSGlueCrawler_recreates (36.35s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (47.06s)
--- PASS: TestAccAWSGlueCrawler_Description (29.08s)
--- PASS: TestAccAWSGlueCrawler_Configuration (36.90s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (44.31s)
--- PASS: TestAccAWSElasticSearchDomain_update (1900.87s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (20.34s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (29.45s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (20.82s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (2087.44s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (28.91s)
--- PASS: TestAccAWSGlueJob_Basic (14.13s)
--- PASS: TestAccAWSGlueCrawler_Schedule (38.22s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (22.64s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (37.10s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (37.75s)
--- PASS: TestAccAWSGlueJob_Command (21.42s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (21.59s)
--- PASS: TestAccAWSGlueCrawler_Tags (46.31s)
--- PASS: TestAccAWSGlueJob_GlueVersion (21.65s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (21.69s)
--- PASS: TestAccAWSGlueJob_MaxRetries (21.63s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (21.59s)
--- PASS: TestAccAWSGlueJob_Timeout (21.96s)
--- PASS: TestAccAWSGlueJob_Description (41.11s)
--- PASS: TestAccAWSGlueJob_Tags (29.86s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (21.63s)
--- PASS: TestAccAWSGlueTrigger_Basic (14.57s)
--- PASS: TestAccAWSGlueJob_WorkerType (28.81s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (21.84s)
--- PASS: TestAccAWSGlueJob_PythonShell (31.39s)
--- PASS: TestAccAWSGlueTrigger_Description (22.46s)
--- PASS: TestAccAWSIAMGroup_basic (16.52s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (16.96s)
--- PASS: TestAccAWSEMRInstanceGroup_BidPrice (1356.03s)
--- PASS: TestAccAWSUser_disappears (7.84s)
--- PASS: TestAccAWSGlueTrigger_Tags (39.14s)
--- PASS: TestAccAWSIAMGroup_nameChange (16.27s)
--- PASS: TestAccAWSUser_basic (17.60s)
--- PASS: TestAccAWSGlueTrigger_Predicate (54.69s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (13.52s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (13.43s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (14.24s)
--- PASS: TestAccAWSGlueTrigger_Enabled (64.99s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (13.62s)
--- PASS: TestAccAWSGlueTrigger_Schedule (59.66s)
--- PASS: TestAccAWSUser_ForceDestroy_SigningCertificate (13.45s)
--- PASS: TestAccAWSGlueTrigger_Crawler (85.82s)
--- PASS: TestAccAWSUser_nameChange (17.34s)
--- PASS: TestAccAWSUser_pathChange (17.59s)
--- PASS: TestAccAWSUser_tags (18.12s)
--- PASS: TestAccAWSUser_permissionsBoundary (38.93s)
--- PASS: TestAccAWSEMRInstanceGroup_EbsConfig_EbsOptimized (1035.20s)
--- PASS: TestAccAWSEksNodeGroup_ForceUpdateVersion (4083.83s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (3984.48s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3673.37s)
--- PASS: TestAccAWSGameliftFleet_basic (1436.98s)
--- PASS: TestAccAWSGameliftFleet_tags (1421.86s)
--- PASS: TestAccAWSGameliftFleet_disappears (1452.20s)
--- PASS: TestAccAWSGameliftFleet_allFields (1550.67s)
--- PASS: TestAccAWSElasticSearchDomain_update_version (3141.52s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3358.73s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (4638.98s)
--- PASS: TestAccAWSEksNodeGroup_Version (5184.55s)

The acceptance test failures are pre-existing failures.

@gdavison gdavison merged commit 18cc5b5 into hashicorp:master Jun 16, 2020
@gdavison gdavison added this to the v2.67.0 milestone Jun 16, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 17, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/acm Issues and PRs that pertain to the acm service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/datasync Issues and PRs that pertain to the datasync service. service/docdb Issues and PRs that pertain to the docdb service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/emr Issues and PRs that pertain to the emr service. service/gamelift Issues and PRs that pertain to the gamelift service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging this pull request may close these issues.

Fix and enable tfproviderlint R005 check: Combine multiple d.HasChange() calls with d.HasChanges() call
4 participants
@jbarnes7952 @bflad @gdavison @breathingdust