Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_api_gateway_stage: Ignore NotFoundException on destroy #12826

Merged
merged 1 commit into from
Apr 29, 2020
Merged

resource/aws_api_gateway_stage: Ignore NotFoundException on destroy #12826

merged 1 commit into from
Apr 29, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12756

Release note for CHANGELOG:

* resource/aws_api_gateway_stage: Ignore `NotFoundException` error on destroy

Previously:

    TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment: testing.go:730: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: Deleting API Gateway Stage failed: NotFoundException: Invalid stage identifier specified

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment (62.18s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (261.86s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings_kinesis (363.46s)
--- PASS: TestAccAWSAPIGatewayStage_basic (407.06s)

@bflad
resource/aws_api_gateway_stage: Ignore NotFoundException on destroy
3b8c80b 
Reference: #12756

Previously:

```
    TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment: testing.go:730: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: Deleting API Gateway Stage failed: NotFoundException: Invalid stage identifier specified
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment (62.18s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (261.86s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings_kinesis (363.46s)
--- PASS: TestAccAWSAPIGatewayStage_basic (407.06s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Apr 15, 2020
@bflad bflad requested a review from a team April 15, 2020 04:31
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 15, 2020
@bflad bflad mentioned this pull request Apr 15, 2020
Closed
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2020
gdavison
gdavison approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment (26.04s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (196.16s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings_kinesis (276.46s)
--- PASS: TestAccAWSAPIGatewayStage_basic (340.72s)

@bflad bflad added this to the v2.60.0 milestone Apr 29, 2020
@bflad bflad merged commit 23192da into master Apr 29, 2020
@bflad bflad deleted the b-aws_api_gateway_stage-NotFoundException-destroy branch April 29, 2020 23:18
bflad added a commit that referenced this pull request Apr 29, 2020
@bflad
Update CHANGELOG for #12826
bf3cde0
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@bflad @adamdecaf
resource/aws_api_gateway_stage: Ignore NotFoundException on destroy (h…
d0cc747 
…ashicorp#12826)

Reference: hashicorp#12756

Previously:

```
    TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment: testing.go:730: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: Deleting API Gateway Stage failed: NotFoundException: Invalid stage identifier specified
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAPIGatewayStage_disappears_ReferencingDeployment (62.18s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (261.86s)
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings_kinesis (363.46s)
--- PASS: TestAccAWSAPIGatewayStage_basic (407.06s)
```
@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.60.0
Development

Successfully merging this pull request may close these issues.

Error: Deleting API Gateway Stage failed: NotFoundException: Invalid stage identifier specified
2 participants
@bflad @gdavison