Support empty associate_public_ip_address in launch_template data sources

[jalaziz]

This ports the changes from #10157 to the launch_template data source.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12067

Release note for CHANGELOG:

BUG FIXES:
* data-source/aws_launch_template: Fix error when associate_public_ip_address is empty

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_tags
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_tags
=== RUN   TestAccAWSLaunchTemplateDataSource_metadataOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_metadataOptions
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_tags
=== CONT  TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (28.96s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (29.06s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (29.14s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (29.30s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (63.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	65.092s

[bflad]

Thanks so much for this bug fix and the well implemented covering acceptance testing, @jalaziz 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLaunchTemplateDataSource_basic (9.56s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (10.47s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (10.52s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (10.51s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (21.20s)

[bflad]

(For curious onlookers, type changes like this are typically breaking changes. The original issue of this argument having 3 possible values has more information about the original resource schema update along with how the implementation was okay to update in that manner. The data source was not updated at the same time and was currently broken without this update as well, hence the merging of this as a bug fix.)

[jalaziz]

Awesome! Thanks for the quick turnaround 🎉

[ghost]

This has been released in version 2.59.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!