Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/placement_group - tag on create #12963

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12945

Release note for CHANGELOG:

resource_aws_placement_group: tag on create

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSPlacementGroup_'
--- PASS: TestAccAWSPlacementGroup_basic (43.92s)
--- PASS: TestAccAWSPlacementGroup_tags (103.95s)
--- PASS: TestAccAWSPlacementGroup_disappears (31.86s)

@DrFaust92 DrFaust92 requested a review from a team April 23, 2020 15:50
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 23, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSPlacementGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSPlacementGroup_ -timeout 120m
=== RUN   TestAccAWSPlacementGroup_basic
=== PAUSE TestAccAWSPlacementGroup_basic
=== RUN   TestAccAWSPlacementGroup_tags
=== PAUSE TestAccAWSPlacementGroup_tags
=== RUN   TestAccAWSPlacementGroup_disappears
=== PAUSE TestAccAWSPlacementGroup_disappears
=== CONT  TestAccAWSPlacementGroup_basic
=== CONT  TestAccAWSPlacementGroup_disappears
=== CONT  TestAccAWSPlacementGroup_tags
--- PASS: TestAccAWSPlacementGroup_disappears (18.28s)
--- PASS: TestAccAWSPlacementGroup_basic (23.97s)
--- PASS: TestAccAWSPlacementGroup_tags (55.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.461s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2020
@bflad bflad added this to the v2.60.0 milestone Apr 24, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as well, thanks @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSPlacementGroup_disappears (6.54s)
--- PASS: TestAccAWSPlacementGroup_basic (8.61s)
--- PASS: TestAccAWSPlacementGroup_tags (18.91s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSPlacementGroup_disappears (2.83s)
--- PASS: TestAccAWSPlacementGroup_basic (3.44s)
--- PASS: TestAccAWSPlacementGroup_tags (7.03s)

@bflad bflad merged commit bca603a into hashicorp:master Apr 24, 2020
bflad added a commit that referenced this pull request Apr 24, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 24, 2020
@DrFaust92 DrFaust92 deleted the r/placement_group_tag_on_create branch June 23, 2020 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_placement_group: Tag-on-create
3 participants